Commit 8a7f841c authored by Xi Cheng's avatar Xi Cheng Committed by Commit Bot

Re-assign a few TODOs to wittman@

Change-Id: Ia542a4fdc9ee86b06b23a20a8d01ea0ae562224f
Reviewed-on: https://chromium-review.googlesource.com/c/1347041Reviewed-by: default avatarMike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610319}
parent 24dd4ecd
...@@ -119,7 +119,7 @@ Win32StackFrameUnwinder::~Win32StackFrameUnwinder() {} ...@@ -119,7 +119,7 @@ Win32StackFrameUnwinder::~Win32StackFrameUnwinder() {}
bool Win32StackFrameUnwinder::TryUnwind(CONTEXT* context, bool Win32StackFrameUnwinder::TryUnwind(CONTEXT* context,
ScopedModuleHandle* module) { ScopedModuleHandle* module) {
#ifdef _WIN64 #ifdef _WIN64
// TODO(chengx): update base::ModuleCache to return a ScopedModuleHandle and // TODO(wittman): update base::ModuleCache to return a ScopedModuleHandle and
// use it for this module lookup. // use it for this module lookup.
ScopedModuleHandle frame_module = ScopedModuleHandle frame_module =
unwind_functions_->GetModuleForProgramCounter(ContextPC(context)); unwind_functions_->GetModuleForProgramCounter(ContextPC(context));
......
...@@ -65,7 +65,7 @@ void CallStackProfileBuilder::OnSampleCompleted( ...@@ -65,7 +65,7 @@ void CallStackProfileBuilder::OnSampleCompleted(
OnSampleCompleted(std::move(frames), 1); OnSampleCompleted(std::move(frames), 1);
} }
// TODO(chengx): record |count| as per-Stacksample metadata in the new proto // TODO(wittman): record |count| as per-Stacksample metadata in the new proto
// format. // format.
void CallStackProfileBuilder::OnSampleCompleted( void CallStackProfileBuilder::OnSampleCompleted(
std::vector<base::StackSamplingProfiler::Frame> frames, std::vector<base::StackSamplingProfiler::Frame> frames,
......
...@@ -23,7 +23,8 @@ namespace { ...@@ -23,7 +23,8 @@ namespace {
// due to profile deserialization when profile uploads are delayed (e.g. due to // due to profile deserialization when profile uploads are delayed (e.g. due to
// being offline). Capping at this threshold loses approximately 0.5% of // being offline). Capping at this threshold loses approximately 0.5% of
// profiles on canary and dev. // profiles on canary and dev.
// TODO(chengx): Remove this threshold after crbug.com/903972 is fixed. //
// TODO(wittman): Remove this threshold after crbug.com/903972 is fixed.
const size_t kMaxPendingProfiles = 1250; const size_t kMaxPendingProfiles = 1250;
// PendingProfiles ------------------------------------------------------------ // PendingProfiles ------------------------------------------------------------
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment