Commit 8aa0f6b5 authored by Angela Yoeurng's avatar Angela Yoeurng Committed by Commit Bot

[omnibox] Update ordering of buttons code in UpdateFromModel()

This shouldn't have any functional changes, just a nice to have
all references in the same order :)

Bug: 1123668
Change-Id: I503650e9520e823941e92f9037ee193034a60d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391729
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: default avatarOrin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804013}
parent 9670bbbc
...@@ -171,6 +171,9 @@ void OmniboxSuggestionButtonRowView::UpdateFromModel() { ...@@ -171,6 +171,9 @@ void OmniboxSuggestionButtonRowView::UpdateFromModel() {
l10n_util::GetStringFUTF16(IDS_ACC_KEYWORD_BUTTON, names.short_name)); l10n_util::GetStringFUTF16(IDS_ACC_KEYWORD_BUTTON, names.short_name));
} }
SetPillButtonVisibility(tab_switch_button_,
OmniboxPopupModel::FOCUSED_BUTTON_TAB_SWITCH);
SetPillButtonVisibility(pedal_button_, SetPillButtonVisibility(pedal_button_,
OmniboxPopupModel::FOCUSED_BUTTON_PEDAL); OmniboxPopupModel::FOCUSED_BUTTON_PEDAL);
if (pedal_button_->GetVisible()) { if (pedal_button_->GetVisible()) {
...@@ -180,9 +183,6 @@ void OmniboxSuggestionButtonRowView::UpdateFromModel() { ...@@ -180,9 +183,6 @@ void OmniboxSuggestionButtonRowView::UpdateFromModel() {
pedal_button_->SetAccessibleName(pedal_strings.accessibility_hint); pedal_button_->SetAccessibleName(pedal_strings.accessibility_hint);
} }
SetPillButtonVisibility(tab_switch_button_,
OmniboxPopupModel::FOCUSED_BUTTON_TAB_SWITCH);
bool is_any_button_visible = keyword_button_->GetVisible() || bool is_any_button_visible = keyword_button_->GetVisible() ||
pedal_button_->GetVisible() || pedal_button_->GetVisible() ||
tab_switch_button_->GetVisible(); tab_switch_button_->GetVisible();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment