Null check in SelectionController::handleGestureLongPress.

In following CL, I accidentally skipped null check for |innerNode|: https://chromium.googlesource.com/chromium/src/+/66f8f14f5560949660ad6efc0b00484d8342a 15e%5E%21/#F4 This has caused null-ref error. BUG=633073 Review-Url: https://codereview.chromium.org/2390613002 Cr-Commit-Position: refs/heads/master@{#422713}

Null check in SelectionController::handleGestureLongPress.
In following CL, I accidentally skipped null check for |innerNode|: https://chromium.googlesource.com/chromium/src/+/66f8f14f5560949660ad6efc0b00484d8342a 15e%5E%21/#F4 This has caused null-ref error. BUG=633073 Review-Url: https://codereview.chromium.org/2390613002 Cr-Commit-Position: refs/heads/master@{#422713}
8afb6434 · yoichio · Commit bot · fc431404 · 8afb6434 · 8afb6434
Commit 8afb6434 authored Oct 03, 2016 by yoichio Committed by Commit bot Oct 04, 2016
2 changed files
--- a/third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html
+++ b/third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html
+<!doctype HTML>
+<html hidden id="html">
+<script src="../../../resources/testharness.js"></script>
+<script src="../../../resources/testharnessreport.js"></script>
+<script>
+test(function () {
+    assert_not_equals(window.eventSender, undefined, 'This test requires eventSender.'); 
+    var x = html.offsetLeft + 10;
+    var y = html.offsetTop + 40;
+    eventSender.gestureLongPress(x, y);
+    html.hidden = "";
+});
+</script>
+</html>
\ No newline at end of file
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -706,9 +706,11 @@ bool SelectionController::handleGestureLongPress(
    return false;
  Node* innerNode = hitTestResult.innerNode();
+  if (!innerNode)
+    return false;
  innerNode->document().updateStyleAndLayoutTree();
-  bool innerNodeIsSelectable = innerNode && (hasEditableStyle(*innerNode) ||
+  bool innerNodeIsSelectable =
-                                             innerNode->canStartSelection());
+      hasEditableStyle(*innerNode) || innerNode->canStartSelection();
  if (!innerNodeIsSelectable)
    return false;