Commit 8b4f7522 authored by wangxianzhu's avatar wangxianzhu Committed by Commit bot

Revert of Call PaintLayer::setNeedsRepaint in...

Revert of Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() (patchset #1 id:1 of https://codereview.chromium.org/1469823004/ )

Reason for revert:
This is incorrect. We missed setNeedsRepaint() of the PaintLayers between the object's enclosingLayer and paintInvalidationContainer's layer.

Original issue's description:
> Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking()
>
> To ensure layer is set needsRepaint().
>
> BUG=536999
> TEST=scrollbars/scrollbar-added-during-drag.html etc with sync painting enabled
>
> Committed: https://crrev.com/4c9d4570c68eddbc58f73b1fb4f4c95614bcf9d3
> Cr-Commit-Position: refs/heads/master@{#361179}

TBR=chrishtr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=536999

Review URL: https://codereview.chromium.org/1475483003

Cr-Commit-Position: refs/heads/master@{#361379}
parent 27114889
......@@ -405,8 +405,6 @@ void LayoutBoxModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRe
void LayoutBoxModelObject::invalidateDisplayItemClientOnBacking(const DisplayItemClientWrapper& displayItemClient, PaintInvalidationReason invalidationReason, const LayoutRect* paintInvalidationRect) const
{
layer()->setNeedsRepaint();
if (layer()->groupedMapping()) {
if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashingLayer()) {
// Note: the subpixel accumulation of layer() does not need to be added here. It is already taken into account.
......
......@@ -1249,12 +1249,16 @@ void LayoutObject::invalidateDisplayItemClient(const DisplayItemClientWrapper& d
DisableCompositingQueryAsserts disabler;
if (const PaintLayer* paintInvalidationLayer = enclosingLayer->enclosingLayerForPaintInvalidationCrossingFrameBoundaries())
paintInvalidationLayer->layoutObject()->invalidateDisplayItemClientOnBacking(displayItemClient, PaintInvalidationFull, nullptr);
enclosingLayer->setNeedsRepaint();
}
}
void LayoutObject::invalidateDisplayItemClients(const LayoutBoxModelObject& paintInvalidationContainer, PaintInvalidationReason invalidationReason, const LayoutRect* paintInvalidationRect) const
{
paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*this, invalidationReason, paintInvalidationRect);
if (PaintLayer* enclosingLayer = this->enclosingLayer())
enclosingLayer->setNeedsRepaint();
}
LayoutRect LayoutObject::boundsRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* paintInvalidationState) const
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment