Commit 8b5b6319 authored by anujk.sharma's avatar anujk.sharma Committed by Commit bot

Changing the order of weak_ptr_factory in src/ui module, to ensure proper...

Changing the order of weak_ptr_factory in src/ui module, to ensure proper cleanup while object is inactive.

BUG=303818

Review URL: https://codereview.chromium.org/533553002

Cr-Commit-Position: refs/heads/master@{#293078}
parent 9e86b4cc
...@@ -26,8 +26,8 @@ MessageBubbleBase::MessageBubbleBase(MessageCenter* message_center, ...@@ -26,8 +26,8 @@ MessageBubbleBase::MessageBubbleBase(MessageCenter* message_center,
: message_center_(message_center), : message_center_(message_center),
tray_(tray), tray_(tray),
bubble_view_(NULL), bubble_view_(NULL),
weak_ptr_factory_(this), max_height_(kMessageBubbleBaseDefaultMaxHeight),
max_height_(kMessageBubbleBaseDefaultMaxHeight) { weak_ptr_factory_(this) {
} }
MessageBubbleBase::~MessageBubbleBase() { MessageBubbleBase::~MessageBubbleBase() {
......
...@@ -70,8 +70,8 @@ class MESSAGE_CENTER_EXPORT MessageBubbleBase { ...@@ -70,8 +70,8 @@ class MESSAGE_CENTER_EXPORT MessageBubbleBase {
MessageCenter* message_center_; MessageCenter* message_center_;
MessageCenterTray* tray_; MessageCenterTray* tray_;
views::TrayBubbleView* bubble_view_; views::TrayBubbleView* bubble_view_;
base::WeakPtrFactory<MessageBubbleBase> weak_ptr_factory_;
int max_height_; int max_height_;
base::WeakPtrFactory<MessageBubbleBase> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(MessageBubbleBase); DISALLOW_COPY_AND_ASSIGN(MessageBubbleBase);
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment