Commit 8b663369 authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Commit Bot

[Sync:USS] Fix flaky MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar

Enable Sync on clients one at a time in order to avoid race conditions.

Bug: 919877
Change-Id: Ic8820cf33c9deb9cae3fbf24df0d2e1846d36cd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506083
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638492}
parent 25e941ab
......@@ -1336,16 +1336,8 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
ASSERT_FALSE(ContainsDuplicateBookmarks(0));
}
// Flaky on windows, see htpp://crbug.com/919877
#if defined(OS_WIN)
#define MAYBE_MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar \
DISABLED_MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar
#else
#define MAYBE_MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar \
MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar
#endif
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MAYBE_MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar) {
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier();
......@@ -1356,8 +1348,14 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
ASSERT_NE(nullptr, AddURL(1, i, title, url));
}
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
// Enable sync on Client 0 and wait until bookmarks are committed.
ASSERT_TRUE(GetClient(0)->SetupSync()) << "GetClient(0)->SetupSync() failed.";
ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
// Enable sync on Client 1 and wait until all bookmarks are merged.
ASSERT_TRUE(GetClient(1)->SetupSync()) << "GetClient(1)->SetupSync() failed.";
ASSERT_TRUE(BookmarksMatchChecker().Wait());
ASSERT_FALSE(ContainsDuplicateBookmarks(0));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment