Commit 8b67fb47 authored by John L Chen's avatar John L Chen Committed by Chromium LUCI CQ

remove BootAttributes related cryptohome APIs

They are not being used.

BUG=b:177880754
TEST=build & unit tests

Change-Id: Ice1d862d56cc6ebdb288515d7f941330e201ace6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639069
Commit-Queue: John L Chen <zuan@chromium.org>
Reviewed-by: default avatarRyo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846014}
parent 63c69e0c
...@@ -533,27 +533,6 @@ class CryptohomeClientImpl : public CryptohomeClient { ...@@ -533,27 +533,6 @@ class CryptohomeClientImpl : public CryptohomeClient {
weak_ptr_factory_.GetWeakPtr(), std::move(callback))); weak_ptr_factory_.GetWeakPtr(), std::move(callback)));
} }
void GetBootAttribute(
const cryptohome::GetBootAttributeRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) override {
CallCryptohomeMethod(cryptohome::kCryptohomeGetBootAttribute, request,
std::move(callback));
}
void SetBootAttribute(
const cryptohome::SetBootAttributeRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) override {
CallCryptohomeMethod(cryptohome::kCryptohomeSetBootAttribute, request,
std::move(callback));
}
void FlushAndSignBootAttributes(
const cryptohome::FlushAndSignBootAttributesRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) override {
CallCryptohomeMethod(cryptohome::kCryptohomeFlushAndSignBootAttributes,
request, std::move(callback));
}
void RemoveFirmwareManagementParametersFromTpm( void RemoveFirmwareManagementParametersFromTpm(
const cryptohome::RemoveFirmwareManagementParametersRequest& request, const cryptohome::RemoveFirmwareManagementParametersRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) override { DBusMethodCallback<cryptohome::BaseReply> callback) override {
......
...@@ -26,8 +26,6 @@ class BaseReply; ...@@ -26,8 +26,6 @@ class BaseReply;
class CheckHealthRequest; class CheckHealthRequest;
class CheckKeyRequest; class CheckKeyRequest;
class EndFingerprintAuthSessionRequest; class EndFingerprintAuthSessionRequest;
class FlushAndSignBootAttributesRequest;
class GetBootAttributeRequest;
class GetKeyDataRequest; class GetKeyDataRequest;
class GetLoginStatusRequest; class GetLoginStatusRequest;
class GetSupportedKeyPoliciesRequest; class GetSupportedKeyPoliciesRequest;
...@@ -39,7 +37,6 @@ class MountGuestRequest; ...@@ -39,7 +37,6 @@ class MountGuestRequest;
class MountRequest; class MountRequest;
class RemoveFirmwareManagementParametersRequest; class RemoveFirmwareManagementParametersRequest;
class RemoveKeyRequest; class RemoveKeyRequest;
class SetBootAttributeRequest;
class SetFirmwareManagementParametersRequest; class SetFirmwareManagementParametersRequest;
class StartFingerprintAuthSessionRequest; class StartFingerprintAuthSessionRequest;
class UnmountRequest; class UnmountRequest;
...@@ -355,30 +352,6 @@ class COMPONENT_EXPORT(CRYPTOHOME_CLIENT) CryptohomeClient { ...@@ -355,30 +352,6 @@ class COMPONENT_EXPORT(CRYPTOHOME_CLIENT) CryptohomeClient {
const cryptohome::EndFingerprintAuthSessionRequest& request, const cryptohome::EndFingerprintAuthSessionRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) = 0; DBusMethodCallback<cryptohome::BaseReply> callback) = 0;
// Asynchronously calls GetBootAttribute method. |callback| is called after
// method call, and with reply protobuf.
// GetBootAttribute gets the value of the specified boot attribute.
virtual void GetBootAttribute(
const cryptohome::GetBootAttributeRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) = 0;
// Asynchronously calls SetBootAttribute method. |callback| is called after
// method call, and with reply protobuf.
// SetBootAttribute sets the value of the specified boot attribute. The value
// won't be available unitl FlushAndSignBootAttributes() is called.
virtual void SetBootAttribute(
const cryptohome::SetBootAttributeRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) = 0;
// Asynchronously calls FlushAndSignBootAttributes method. |callback| is
// called after method call, and with reply protobuf.
// FlushAndSignBootAttributes makes all pending boot attribute settings
// available, and have them signed by a special TPM key. This method always
// fails after any user, publuc, or guest session starts.
virtual void FlushAndSignBootAttributes(
const cryptohome::FlushAndSignBootAttributesRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) = 0;
// Asynchronously calls MigrateToDircrypto method. It tells cryptohomed to // Asynchronously calls MigrateToDircrypto method. It tells cryptohomed to
// start migration, and is immediately called back by |callback|. The actual // start migration, and is immediately called back by |callback|. The actual
// result response is done via DircryptoMigrationProgress callback with its // result response is done via DircryptoMigrationProgress callback with its
......
...@@ -407,28 +407,6 @@ void FakeCryptohomeClient::MassRemoveKeys( ...@@ -407,28 +407,6 @@ void FakeCryptohomeClient::MassRemoveKeys(
ReturnProtobufMethodCallback(cryptohome::BaseReply(), std::move(callback)); ReturnProtobufMethodCallback(cryptohome::BaseReply(), std::move(callback));
} }
void FakeCryptohomeClient::GetBootAttribute(
const cryptohome::GetBootAttributeRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) {
cryptohome::BaseReply reply;
cryptohome::GetBootAttributeReply* attr_reply =
reply.MutableExtension(cryptohome::GetBootAttributeReply::reply);
attr_reply->set_value("");
ReturnProtobufMethodCallback(reply, std::move(callback));
}
void FakeCryptohomeClient::SetBootAttribute(
const cryptohome::SetBootAttributeRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) {
ReturnProtobufMethodCallback(cryptohome::BaseReply(), std::move(callback));
}
void FakeCryptohomeClient::FlushAndSignBootAttributes(
const cryptohome::FlushAndSignBootAttributesRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) {
ReturnProtobufMethodCallback(cryptohome::BaseReply(), std::move(callback));
}
void FakeCryptohomeClient::MigrateToDircrypto( void FakeCryptohomeClient::MigrateToDircrypto(
const cryptohome::AccountIdentifier& cryptohome_id, const cryptohome::AccountIdentifier& cryptohome_id,
const cryptohome::MigrateToDircryptoRequest& request, const cryptohome::MigrateToDircryptoRequest& request,
......
...@@ -122,15 +122,6 @@ class COMPONENT_EXPORT(CRYPTOHOME_CLIENT) FakeCryptohomeClient ...@@ -122,15 +122,6 @@ class COMPONENT_EXPORT(CRYPTOHOME_CLIENT) FakeCryptohomeClient
const cryptohome::AuthorizationRequest& auth, const cryptohome::AuthorizationRequest& auth,
const cryptohome::MassRemoveKeysRequest& request, const cryptohome::MassRemoveKeysRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) override; DBusMethodCallback<cryptohome::BaseReply> callback) override;
void GetBootAttribute(
const cryptohome::GetBootAttributeRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) override;
void SetBootAttribute(
const cryptohome::SetBootAttributeRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) override;
void FlushAndSignBootAttributes(
const cryptohome::FlushAndSignBootAttributesRequest& request,
DBusMethodCallback<cryptohome::BaseReply> callback) override;
void MigrateToDircrypto(const cryptohome::AccountIdentifier& cryptohome_id, void MigrateToDircrypto(const cryptohome::AccountIdentifier& cryptohome_id,
const cryptohome::MigrateToDircryptoRequest& request, const cryptohome::MigrateToDircryptoRequest& request,
VoidDBusMethodCallback callback) override; VoidDBusMethodCallback callback) override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment