Commit 8b6aef14 authored by Yi Gu's avatar Yi Gu Committed by Chromium LUCI CQ

[CodeHealth] Convert c/b/extensions/ from base::Bind and base::Callback to Once/Repeating

Bug: 1152279
Change-Id: Ib3ba70a5b7ebb25bed2faada69c48f300b0ff18a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595462Reviewed-by: default avatarFilip Gorski <fgorski@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838245}
parent 593304b4
......@@ -84,11 +84,11 @@ using testing::_;
namespace {
void StoreDigest(std::vector<uint8_t>* digest,
const base::Closure& callback,
base::OnceClosure callback,
base::Value value) {
ASSERT_TRUE(value.is_blob()) << "Unexpected value in StoreDigest";
digest->assign(value.GetBlob().begin(), value.GetBlob().end());
callback.Run();
std::move(callback).Run();
}
bool RsaSignRawData(uint16_t openssl_signature_algorithm,
......
......@@ -319,8 +319,8 @@ ExtensionFunction::ResponseAction PermissionsRequestFunction::Run() {
install_ui_.reset(new ExtensionInstallPrompt(
Profile::FromBrowserContext(browser_context()), native_window));
install_ui_->ShowDialog(
base::Bind(&PermissionsRequestFunction::OnInstallPromptDone,
base::RetainedRef(this)),
base::BindOnce(&PermissionsRequestFunction::OnInstallPromptDone,
base::RetainedRef(this)),
extension(), nullptr,
std::make_unique<ExtensionInstallPrompt::Prompt>(
ExtensionInstallPrompt::PERMISSIONS_PROMPT),
......
......@@ -253,8 +253,9 @@ bool ChromeRuntimeAPIDelegate::CheckForUpdates(
extensions::ExtensionUpdater::CheckParams params;
params.ids = {extension_id};
params.callback = base::Bind(&ChromeRuntimeAPIDelegate::UpdateCheckComplete,
base::Unretained(this), extension_id);
params.callback =
base::BindOnce(&ChromeRuntimeAPIDelegate::UpdateCheckComplete,
base::Unretained(this), extension_id);
updater->CheckNow(std::move(params));
}
return true;
......
......@@ -140,7 +140,7 @@ TEST_F(UDPSocketUnitTest, TestUDPMulticastLoopbackMode) {
// Send a test multicast packet every second.
// Once the target socket received the packet, the message loop will exit.
static void SendMulticastPacket(const base::Closure& quit_run_loop,
static void SendMulticastPacket(base::OnceClosure quit_run_loop,
UDPSocket* src,
int result) {
if (result == 0) {
......@@ -149,15 +149,16 @@ static void SendMulticastPacket(const base::Closure& quit_run_loop,
src->Write(data, kTestMessageLength, base::BindOnce(&OnSendCompleted));
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE,
base::BindOnce(&SendMulticastPacket, quit_run_loop, src, result),
base::BindOnce(&SendMulticastPacket, std::move(quit_run_loop), src,
result),
base::TimeDelta::FromSeconds(1));
} else {
quit_run_loop.Run();
std::move(quit_run_loop).Run();
FAIL() << "Failed to connect to multicast address. Error code: " << result;
}
}
static void OnMulticastReadCompleted(const base::Closure& quit_run_loop,
static void OnMulticastReadCompleted(base::OnceClosure quit_run_loop,
bool* packet_received,
int count,
scoped_refptr<net::IOBuffer> io_buffer,
......@@ -167,7 +168,7 @@ static void OnMulticastReadCompleted(const base::Closure& quit_run_loop,
EXPECT_EQ(kTestMessageLength, count);
EXPECT_EQ(0, strncmp(io_buffer->data(), kTestMessage, kTestMessageLength));
*packet_received = true;
quit_run_loop.Run();
std::move(quit_run_loop).Run();
}
TEST_F(UDPSocketUnitTest, TestUDPMulticastRecv) {
......
......@@ -194,7 +194,7 @@ class WebNavigationApiTest : public ExtensionApiTest {
public:
WebNavigationApiTest() {
embedded_test_server()->RegisterRequestHandler(
base::Bind(&HandleTestRequest));
base::BindRepeating(&HandleTestRequest));
}
~WebNavigationApiTest() override {}
......
......@@ -1081,7 +1081,7 @@ IN_PROC_BROWSER_TEST_F(ContentScriptApiTest, ContentScriptUrls) {
[](const content::WebContentsConsoleObserver::Message& message) {
return message.message == base::ASCIIToUTF16("TestMessage");
};
observer.SetFilter(base::Bind(filter));
observer.SetFilter(base::BindRepeating(filter));
ui_test_utils::NavigateToURL(
browser(), embedded_test_server()->GetURL(host, "/simple.html"));
ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
......
......@@ -63,7 +63,7 @@ void VerifyPromptPermissionsCallback(
}
void VerifyPromptWithholdingUICallback(
base::Closure quit_closure,
base::OnceClosure quit_closure,
const bool should_display,
ExtensionInstallPromptShowParams* params,
ExtensionInstallPrompt::DoneCallback done_callback,
......@@ -73,10 +73,10 @@ void VerifyPromptWithholdingUICallback(
}
void SetImage(gfx::Image* image_out,
const base::Closure& quit_closure,
base::OnceClosure quit_closure,
const gfx::Image& image_in) {
*image_out = image_in;
quit_closure.Run();
std::move(quit_closure).Run();
}
class ExtensionInstallPromptUnitTest : public testing::Test {
......
......@@ -13,9 +13,9 @@ ExtensionApiTestWithManagementPolicy::~ExtensionApiTestWithManagementPolicy() {}
void ExtensionApiTestWithManagementPolicy::SetUpInProcessBrowserTestFixture() {
extensions::ExtensionApiTest::SetUpInProcessBrowserTestFixture();
embedded_test_server()->RegisterRequestMonitor(
base::Bind(&ExtensionApiTestWithManagementPolicy::MonitorRequestHandler,
base::Unretained(this)));
embedded_test_server()->RegisterRequestMonitor(base::BindRepeating(
&ExtensionApiTestWithManagementPolicy::MonitorRequestHandler,
base::Unretained(this)));
ON_CALL(policy_provider_, IsInitializationComplete(testing::_))
.WillByDefault(testing::Return(true));
ON_CALL(policy_provider_, IsFirstPolicyLoadComplete(testing::_))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment