Commit 8b759729 authored by Dale Curtis's avatar Dale Curtis Committed by Commit Bot

Disable flaky MediaEngagement browser tests on ChromeOS.

BUG=1019671
TBR=mlamouri

Change-Id: I26e2ac7d14c49a39fb3a368769dba06903871db6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898097Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712273}
parent e394a753
...@@ -369,8 +369,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, ...@@ -369,8 +369,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
ExpectScores(1, 0, 1, 0); ExpectScores(1, 0, 1, 0);
} }
// Flaky tests on CrOS: http://crbug.com/1019671.
#if defined(OS_CHROMEOS)
#define MAYBE_DoNotRecordEngagement_NotTime_AudioOnly \
DISABLED_DoNotRecordEngagement_NotTime_AudioOnly
#else
#define MAYBE_DoNotRecordEngagement_NotTime_AudioOnly \
DoNotRecordEngagement_NotTime_AudioOnly
#endif
IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
DoNotRecordEngagement_NotTime_AudioOnly) { MAYBE_DoNotRecordEngagement_NotTime_AudioOnly) {
LoadTestPageAndWaitForPlayAndAudible("engagement_test_audio.html", false); LoadTestPageAndWaitForPlayAndAudible("engagement_test_audio.html", false);
Advance(base::TimeDelta::FromSeconds(1)); Advance(base::TimeDelta::FromSeconds(1));
CloseTab(); CloseTab();
...@@ -385,8 +393,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, ...@@ -385,8 +393,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
ExpectScores(1, 0, 1, 0); ExpectScores(1, 0, 1, 0);
} }
// Flaky tests on CrOS: http://crbug.com/1019671.
#if defined(OS_CHROMEOS)
#define MAYBE_DoNotRecordEngagement_TabMuted_AudioOnly \
DISABLED_DoNotRecordEngagement_TabMuted_AudioOnly
#else
#define MAYBE_DoNotRecordEngagement_TabMuted_AudioOnly \
DoNotRecordEngagement_TabMuted_AudioOnly
#endif
IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
DoNotRecordEngagement_TabMuted_AudioOnly) { MAYBE_DoNotRecordEngagement_TabMuted_AudioOnly) {
LoadTestPageAndWaitForPlayAndAudible("engagement_test_audio.html", true); LoadTestPageAndWaitForPlayAndAudible("engagement_test_audio.html", true);
AdvanceMeaningfulPlaybackTime(); AdvanceMeaningfulPlaybackTime();
CloseTab(); CloseTab();
...@@ -421,8 +437,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, ...@@ -421,8 +437,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
ExpectScores(1, 0, 1, 0); ExpectScores(1, 0, 1, 0);
} }
// Flaky tests on CrOS: http://crbug.com/1019671.
#if defined(OS_CHROMEOS)
#define MAYBE_DoNotRecordEngagement_PlaybackStopped_AudioOnly \
DISABLED_DoNotRecordEngagement_PlaybackStopped_AudioOnly
#else
#define MAYBE_DoNotRecordEngagement_PlaybackStopped_AudioOnly \
DoNotRecordEngagement_PlaybackStopped_AudioOnly
#endif
IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
DoNotRecordEngagement_PlaybackStopped_AudioOnly) { MAYBE_DoNotRecordEngagement_PlaybackStopped_AudioOnly) {
LoadTestPageAndWaitForPlayAndAudible("engagement_test_audio.html", false); LoadTestPageAndWaitForPlayAndAudible("engagement_test_audio.html", false);
Advance(base::TimeDelta::FromSeconds(1)); Advance(base::TimeDelta::FromSeconds(1));
ExecuteScript("document.getElementById(\"media\").pause();"); ExecuteScript("document.getElementById(\"media\").pause();");
...@@ -440,8 +464,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, ...@@ -440,8 +464,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
ExpectScores(1, 1, 1, 1); ExpectScores(1, 1, 1, 1);
} }
// Flaky tests on CrOS: http://crbug.com/1019671.
#if defined(OS_CHROMEOS)
#define MAYBE_RecordEngagement_NotVisible_AudioOnly \
DISABLED_RecordEngagement_NotVisible_AudioOnly
#else
#define MAYBE_RecordEngagement_NotVisible_AudioOnly \
RecordEngagement_NotVisible_AudioOnly
#endif
IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
RecordEngagement_NotVisible_AudioOnly) { MAYBE_RecordEngagement_NotVisible_AudioOnly) {
LoadTestPageAndWaitForPlayAndAudible("engagement_test_audio.html", false); LoadTestPageAndWaitForPlayAndAudible("engagement_test_audio.html", false);
OpenTabAsLink(); OpenTabAsLink();
AdvanceMeaningfulPlaybackTime(); AdvanceMeaningfulPlaybackTime();
...@@ -516,8 +548,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, RecordVisitOnNewOrigin) { ...@@ -516,8 +548,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, RecordVisitOnNewOrigin) {
ExpectScores(1, 0, 1, 0); ExpectScores(1, 0, 1, 0);
} }
// Flaky tests on CrOS: http://crbug.com/1019671.
#if defined(OS_CHROMEOS)
#define MAYBE_DoNotRecordEngagement_SilentAudioTrack_AudioOnly \
DISABLED_DoNotRecordEngagement_SilentAudioTrack_AudioOnly
#else
#define MAYBE_DoNotRecordEngagement_SilentAudioTrack_AudioOnly \
DoNotRecordEngagement_SilentAudioTrack_AudioOnly
#endif
IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
DoNotRecordEngagement_SilentAudioTrack_AudioOnly) { MAYBE_DoNotRecordEngagement_SilentAudioTrack_AudioOnly) {
LoadTestPageAndWaitForPlay( LoadTestPageAndWaitForPlay(
http_server().GetURL("/engagement_test_silent_audio_track_audio.html"), http_server().GetURL("/engagement_test_silent_audio_track_audio.html"),
false); false);
...@@ -563,7 +603,13 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, ...@@ -563,7 +603,13 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
ExpectScores(1, 1, 1, 1); ExpectScores(1, 1, 1, 1);
} }
IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, MultipleElements) { // Flaky tests on CrOS: http://crbug.com/1019671.
#if defined(OS_CHROMEOS)
#define MAYBE_MultipleElements DISABLED_MultipleElements
#else
#define MAYBE_MultipleElements MultipleElements
#endif
IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, MAYBE_MultipleElements) {
LoadTestPageAndWaitForPlayAndAudible("engagement_test_multiple.html", false); LoadTestPageAndWaitForPlayAndAudible("engagement_test_multiple.html", false);
AdvanceMeaningfulPlaybackTime(); AdvanceMeaningfulPlaybackTime();
CloseTab(); CloseTab();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment