Commit 8b9f3458 authored by Peter Beverloo's avatar Peter Beverloo Committed by Commit Bot

Don't display a settings gear on non-MD extension notifications

Inline settings work fine for the MD notifications, but the handler
doesn't implement OpenSettings() for non-MD notifications, nor has
something sensible to do there. Instead, don't display the button.

Bug: 828346
Change-Id: I3a57f940be773e40e4994e4e6e1920f0c83ca3ec
Reviewed-on: https://chromium-review.googlesource.com/1002812Reviewed-by: default avatarTetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549207}
parent 0a5b400f
...@@ -361,7 +361,7 @@ bool NotificationsApiFunction::CreateNotification( ...@@ -361,7 +361,7 @@ bool NotificationsApiFunction::CreateNotification(
optional_fields.settings_button_handler = optional_fields.settings_button_handler =
base::FeatureList::IsEnabled(message_center::kNewStyleNotifications) base::FeatureList::IsEnabled(message_center::kNewStyleNotifications)
? message_center::SettingsButtonHandler::INLINE ? message_center::SettingsButtonHandler::INLINE
: message_center::SettingsButtonHandler::DELEGATE; : message_center::SettingsButtonHandler::NONE;
// TODO(crbug.com/772004): Remove the manual limitation in favor of an IDL // TODO(crbug.com/772004): Remove the manual limitation in favor of an IDL
// annotation once supported. // annotation once supported.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment