Commit 8bb1f09e authored by Keren Zhu's avatar Keren Zhu Committed by Commit Bot

Always wait on subprocess in BrowserUiTest

Subprocesses spawned in the same process group with their parent are
killed when the parent test process exits. This CL makes BrowserUiTest
always wait on the subprocess so that those tests in the subprocess are
actually run.

Bug: 1128222, 688534, 1094369
Change-Id: I2ee1059fa4968be2c2c62a3834e5f70e883f7caf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412690Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807160}
parent f9584fa9
...@@ -68,13 +68,9 @@ TEST(BrowserUiTest, Invoke) { ...@@ -68,13 +68,9 @@ TEST(BrowserUiTest, Invoke) {
base::LaunchOptions options; base::LaunchOptions options;
#if defined(OS_WIN) // Wait on subprocess. Otherwise the whole process group will be killed on
// Under Windows, the child process won't launch without the wait option. // parent process exit. See http://crbug.com/1094369.
// See http://crbug.com/688534.
options.wait = true; options.wait = true;
#else
options.wait = !command.HasSwitch(switches::kTestLauncherInteractive);
#endif
base::LaunchProcess(command, options); base::LaunchProcess(command, options);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment