Skip to content

GitLab

T
tangled
Commit 8bdec06d authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot
Browse files
Options

[LayoutNG] Fix |Reset()| to reset unpositioned list marker 

This patch fixes |NGLineBoxFragmentBuilder::Reset()| to reset
unpositioned list marker.

Bug: 967997
Change-Id: Ic776ac0881db2261da8e9a443c251c42554a39cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662984
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670049}
parent ea6a9a26
Hide whitespace changes
Inline Side-by-side
Showing with 18 additions and 0 deletions
third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.cc
View file @ 8bdec06d
......@@ -19,6 +19,7 @@ void NGLineBoxFragmentBuilder::Reset() {
child_break_tokens_.Shrink(0);
inline_break_tokens_.Shrink(0);
oof_positioned_candidates_.Shrink(0);
unpositioned_list_marker_ = NGUnpositionedListMarker();
size_.inline_size = LayoutUnit();
metrics_ = NGLineHeightMetrics();
......
third_party/blink/web_tests/external/wpt/css/CSS2/floats/list-item-taller-than-opportunity-001.html 0 → 100644
View file @ 8bdec06d
<!DOCTYPE html>
<title>List item taller than the first opportunity should not crash</title>
<link rel="author" title="Koji Ishii" href="mailto:kojii@chromium.org">
<link rel="help" href="https://www.w3.org/TR/CSS22/visuren.html#float-position" title="9.5.1 Positioning the float: the 'float' property">
<link rel="help" href="http://crbug.com/967997">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<body>
<div style="float: left; width: 5px; height: 5px;"></div>
<div style="clear: left; float: left; width: 10px; height: 5px;"></div>
<ul>
<li></li>
</ul>
<script>
test(() => {}, "Layout should not crash");
</script>
</body>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment