Commit 8bff665c authored by Yue Li's avatar Yue Li Committed by Commit Bot

Update Assistant options for voice match verification

Copied from email thread:
EnableRequireVoiceMatchVerification option is intended to be used
independent of whether or not the user has speaker id models on-device
(i.e. Libassistant ignores that option if user has no SID model).
The downside of conditionally enabling it would be: If the speech
pipeline is already running when that option is set, the change won't
take effect until next Speech pipeline restart (b/120241931).

Bug: b/120241931
Test: Manual Test
Change-Id: I0deef204ef5c6dd9ee36acbb5074d1a2e47731c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824676Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700389}
parent aa7d25ea
...@@ -1199,9 +1199,7 @@ void AssistantManagerServiceImpl::UpdateInternalOptions( ...@@ -1199,9 +1199,7 @@ void AssistantManagerServiceImpl::UpdateInternalOptions(
assistant_client::InternalOptions::UserCredentialMode::SIGNED_OUT); assistant_client::InternalOptions::UserCredentialMode::SIGNED_OUT);
} }
if (assistant_settings_manager_->speaker_id_enrollment_done()) { internal_options->EnableRequireVoiceMatchVerification();
internal_options->EnableRequireVoiceMatchVerification();
}
assistant_manager_internal->SetOptions(*internal_options, [](bool success) { assistant_manager_internal->SetOptions(*internal_options, [](bool success) {
DVLOG(2) << "set options: " << success; DVLOG(2) << "set options: " << success;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment