Commit 8c0b4011 authored by Vasilii Sukhanov's avatar Vasilii Sukhanov Committed by Commit Bot

Disable some PDF unit tests on Linux.

AccessibilityTest.GetAccessibilityLinkInfo
AccessibilityTest.GetAccessibilityPage
PDFiumPageLinkTest.TestAnnotLinkGeneration
PDFiumPageLinkTest.TestLinkGeneration
PDFiumPageTextTest.GetTextRunInfo
PDFiumPageTextTest.TestHighlightTextRunInfo

Tbr: thestig@chromium.org
Bug: 1135988
Change-Id: Ibf3a150a812a402e7e604c382d0d1fd372c4ccbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454076Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814622}
parent 3fc224bf
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include <string> #include <string>
#include "build/build_config.h"
#include "pdf/pdfium/pdfium_engine.h" #include "pdf/pdfium/pdfium_engine.h"
#include "pdf/pdfium/pdfium_test_base.h" #include "pdf/pdfium/pdfium_test_base.h"
#include "pdf/ppapi_migration/geometry_conversions.h" #include "pdf/ppapi_migration/geometry_conversions.h"
...@@ -39,7 +40,13 @@ double GetExpectedCharWidth(bool is_chromeos, size_t i, double expected) { ...@@ -39,7 +40,13 @@ double GetExpectedCharWidth(bool is_chromeos, size_t i, double expected) {
// update the GetExpected... functions above. If that becomes too much of a // update the GetExpected... functions above. If that becomes too much of a
// burden, consider changing the checks to just make sure the font metrics look // burden, consider changing the checks to just make sure the font metrics look
// sane. // sane.
TEST_F(AccessibilityTest, GetAccessibilityPage) { // Flaky on Linux only. http://crbug.com/1135988
#if defined(OS_LINUX)
#define MAYBE_GetAccessibilityPage DISABLED_GetAccessibilityPage
#else
#define MAYBE_GetAccessibilityPage GetAccessibilityPage
#endif
TEST_F(AccessibilityTest, MAYBE_GetAccessibilityPage) {
static constexpr size_t kExpectedTextRunCount = 2; static constexpr size_t kExpectedTextRunCount = 2;
struct { struct {
uint32_t len; uint32_t len;
...@@ -451,7 +458,13 @@ TEST_F(AccessibilityTest, TestInternalLinkClickActionHandling) { ...@@ -451,7 +458,13 @@ TEST_F(AccessibilityTest, TestInternalLinkClickActionHandling) {
EXPECT_TRUE(client.url().empty()); EXPECT_TRUE(client.url().empty());
} }
TEST_F(AccessibilityTest, GetAccessibilityLinkInfo) { // Flaky on Linux only. http://crbug.com/1135988
#if defined(OS_LINUX)
#define MAYBE_GetAccessibilityLinkInfo DISABLED_GetAccessibilityLinkInfo
#else
#define MAYBE_GetAccessibilityLinkInfo GetAccessibilityLinkInfo
#endif
TEST_F(AccessibilityTest, MAYBE_GetAccessibilityLinkInfo) {
// Clone of pp::PDF::PrivateAccessibilityLinkInfo. // Clone of pp::PDF::PrivateAccessibilityLinkInfo.
struct { struct {
std::string url; std::string url;
......
...@@ -14,6 +14,7 @@ ...@@ -14,6 +14,7 @@
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
#include "base/strings/stringprintf.h" #include "base/strings/stringprintf.h"
#include "base/test/gtest_util.h" #include "base/test/gtest_util.h"
#include "build/build_config.h"
#include "cc/test/pixel_comparator.h" #include "cc/test/pixel_comparator.h"
#include "cc/test/pixel_test_utils.h" #include "cc/test/pixel_test_utils.h"
#include "pdf/pdfium/pdfium_engine.h" #include "pdf/pdfium/pdfium_engine.h"
...@@ -140,7 +141,13 @@ class PDFiumPageLinkTest : public PDFiumTestBase { ...@@ -140,7 +141,13 @@ class PDFiumPageLinkTest : public PDFiumTestBase {
} }
}; };
TEST_F(PDFiumPageLinkTest, TestLinkGeneration) { // Flaky on Linux only. http://crbug.com/1135988
#if defined(OS_LINUX)
#define MAYBE_TestLinkGeneration DISABLED_TestLinkGeneration
#else
#define MAYBE_TestLinkGeneration TestLinkGeneration
#endif
TEST_F(PDFiumPageLinkTest, MAYBE_TestLinkGeneration) {
TestClient client; TestClient client;
std::unique_ptr<PDFiumEngine> engine = std::unique_ptr<PDFiumEngine> engine =
InitializeEngine(&client, FILE_PATH_LITERAL("weblinks.pdf")); InitializeEngine(&client, FILE_PATH_LITERAL("weblinks.pdf"));
...@@ -182,7 +189,13 @@ TEST_F(PDFiumPageLinkTest, TestLinkGeneration) { ...@@ -182,7 +189,13 @@ TEST_F(PDFiumPageLinkTest, TestLinkGeneration) {
EXPECT_EQ(gfx::Rect(82, 67, 161, 21), third_link.bounding_rects[0]); EXPECT_EQ(gfx::Rect(82, 67, 161, 21), third_link.bounding_rects[0]);
} }
TEST_F(PDFiumPageLinkTest, TestAnnotLinkGeneration) { // Flaky on Linux only. http://crbug.com/1135988
#if defined(OS_LINUX)
#define MAYBE_TestAnnotLinkGeneration DISABLED_TestAnnotLinkGeneration
#else
#define MAYBE_TestAnnotLinkGeneration TestAnnotLinkGeneration
#endif
TEST_F(PDFiumPageLinkTest, MAYBE_TestAnnotLinkGeneration) {
struct ExpectedLink { struct ExpectedLink {
int32_t start_char_index; int32_t start_char_index;
int32_t char_count; int32_t char_count;
...@@ -350,7 +363,13 @@ TEST_F(PDFiumPageTextTest, TestTextRunBounds) { ...@@ -350,7 +363,13 @@ TEST_F(PDFiumPageTextTest, TestTextRunBounds) {
engine->GetCharBounds(kPageIndex, kSecondRunEndIndex))); engine->GetCharBounds(kPageIndex, kSecondRunEndIndex)));
} }
TEST_F(PDFiumPageTextTest, GetTextRunInfo) { // Flaky on Linux only. http://crbug.com/1135988
#if defined(OS_LINUX)
#define MAYBE_GetTextRunInfo DISABLED_GetTextRunInfo
#else
#define MAYBE_GetTextRunInfo GetTextRunInfo
#endif
TEST_F(PDFiumPageTextTest, MAYBE_GetTextRunInfo) {
TestClient client; TestClient client;
std::unique_ptr<PDFiumEngine> engine = std::unique_ptr<PDFiumEngine> engine =
InitializeEngine(&client, FILE_PATH_LITERAL("weblinks.pdf")); InitializeEngine(&client, FILE_PATH_LITERAL("weblinks.pdf"));
...@@ -422,7 +441,13 @@ TEST_F(PDFiumPageTextTest, GetTextRunInfo) { ...@@ -422,7 +441,13 @@ TEST_F(PDFiumPageTextTest, GetTextRunInfo) {
ASSERT_FALSE(text_run_info_result.has_value()); ASSERT_FALSE(text_run_info_result.has_value());
} }
TEST_F(PDFiumPageTextTest, TestHighlightTextRunInfo) { // Flaky on Linux only. http://crbug.com/1135988
#if defined(OS_LINUX)
#define MAYBE_TestHighlightTextRunInfo DISABLED_TestHighlightTextRunInfo
#else
#define MAYBE_TestHighlightTextRunInfo TestHighlightTextRunInfo
#endif
TEST_F(PDFiumPageTextTest, MAYBE_TestHighlightTextRunInfo) {
TestClient client; TestClient client;
std::unique_ptr<PDFiumEngine> engine = std::unique_ptr<PDFiumEngine> engine =
InitializeEngine(&client, FILE_PATH_LITERAL("highlights.pdf")); InitializeEngine(&client, FILE_PATH_LITERAL("highlights.pdf"));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment