[ios] Bookmarks UI Refresh polishing.

- Hides the toolbar border for Edit Folder and Edit Bookmark.
- Removes the Done Button on the Folder Picker.
- Adds separators to BookmarksHomeTableView.
- Removes white background from FolderPicker.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I26e58dcdb1c65761cf10c7a6956778b02df0b16a
Reviewed-on: https://chromium-review.googlesource.com/1098516
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567132}

ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm

@@ -258,6 +258,10 @@ typedef NS_ENUM(NSInteger, ItemType) {
 
   if (experimental_flags::IsBookmarksUIRebootEnabled()) {
     deleteButton.tintColor = [UIColor redColor];
+    // Setting the image to nil will cause the default shadowImage to be used,
+    // we need to create a new one.
+    [self.navigationController.toolbar setShadowImage:[UIImage new]
+                                   forToolbarPosition:UIBarPositionAny];
     [self setToolbarItems:@[ spaceButton, deleteButton, spaceButton ]
                  animated:NO];
   } else {

ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm

@@ -488,6 +488,8 @@ folderEditorWithBookmarkModel:(bookmarks::BookmarkModel*)bookmarkModel
 
   if (experimental_flags::IsBookmarksUIRebootEnabled()) {
     deleteButton.tintColor = [UIColor redColor];
+    [self.navigationController.toolbar setShadowImage:[UIImage new]
+                                   forToolbarPosition:UIBarPositionAny];
     [self setToolbarItems:@[ spaceButton, deleteButton, spaceButton ]
                  animated:NO];
   } else {

ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm

@@ -158,21 +158,22 @@ using bookmarks::BookmarkNode;
   if ([self respondsToSelector:@selector(setEdgesForExtendedLayout:)]) {
     [self setEdgesForExtendedLayout:UIRectEdgeNone];
   }
-  self.view.backgroundColor = [UIColor whiteColor];
   self.view.accessibilityIdentifier =
       kBookmarkFolderPickerViewContainerIdentifier;
-
   self.title = l10n_util::GetNSString(IDS_IOS_BOOKMARK_CHOOSE_GROUP_BUTTON);
 
-  UIBarButtonItem* doneItem = [[UIBarButtonItem alloc]
-      initWithTitle:l10n_util::GetNSString(
-                        IDS_IOS_BOOKMARK_EDIT_MODE_EXIT_MOBILE)
-              style:UIBarButtonItemStylePlain
-             target:self
-             action:@selector(done:)];
-  doneItem.accessibilityIdentifier =
-      kBookmarkFolderEditNavigationBarDoneButtonIdentifier;
-  self.navigationItem.rightBarButtonItem = doneItem;
+  if (!experimental_flags::IsBookmarksUIRebootEnabled()) {
+    self.view.backgroundColor = [UIColor whiteColor];
+    UIBarButtonItem* doneItem = [[UIBarButtonItem alloc]
+        initWithTitle:l10n_util::GetNSString(
+                          IDS_IOS_BOOKMARK_EDIT_MODE_EXIT_MOBILE)
+                style:UIBarButtonItemStylePlain
+               target:self
+               action:@selector(done:)];
+    doneItem.accessibilityIdentifier =
+        kBookmarkFolderEditNavigationBarDoneButtonIdentifier;
+    self.navigationItem.rightBarButtonItem = doneItem;
+  }
 
   if (self.allowsCancel) {
     UIBarButtonItem* cancelItem =

ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm

@@ -358,24 +358,26 @@ const CGFloat kShadowRadius = 12.0f;
 - (void)viewDidLoad {
   [super viewDidLoad];
 
-  // Set Navigation Bar and Toolbar appearance.
+  // Set Navigation Bar, Toolbar and TableView appearance.
   if (experimental_flags::IsBookmarksUIRebootEnabled()) {
     self.navigationController.navigationBarHidden = NO;
     self.navigationController.toolbar.translucent = YES;
+    // Add a tableFooterView in order to disable separators at the bottom of the
+    // tableView.
+    self.tableView.tableFooterView = [[UIView alloc] init];
   } else {
     self.navigationController.navigationBarHidden = YES;
     self.navigationController.toolbar.translucent = NO;
     self.navigationController.toolbar.barTintColor = [UIColor whiteColor];
     self.navigationController.toolbar.layer.shadowRadius = kShadowRadius;
     self.navigationController.toolbar.layer.shadowOpacity = kShadowOpacity;
+    // Disable separators while the loading spinner is showing.
+    // |loadBookmarkView| will bring them back if needed.
+    self.tableView.separatorStyle = UITableViewCellSeparatorStyleNone;
   }
   self.navigationController.toolbar.accessibilityIdentifier =
       kBookmarkHomeUIToolbarIdentifier;
 
-  // Disable separators while the loading spinner is showing. |loadBookmarkView|
-  // will bring them back if needed.
-  self.tableView.separatorStyle = UITableViewCellSeparatorStyleNone;
-
   if (self.bookmarks->loaded()) {
     [self loadBookmarkViews];
   } else {
@@ -451,8 +453,11 @@ const CGFloat kShadowRadius = 12.0f;
       [BookmarkHomeSharedState cellHeightPt];
   self.tableView.sectionHeaderHeight = 0;
   self.tableView.sectionFooterHeight = 0;
-  self.sharedState.tableView.separatorStyle = UITableViewCellSeparatorStyleNone;
   self.sharedState.tableView.allowsMultipleSelectionDuringEditing = YES;
+  if (!experimental_flags::IsBookmarksUIRebootEnabled()) {
+    self.sharedState.tableView.separatorStyle =
+        UITableViewCellSeparatorStyleNone;
+  }
 
   UILongPressGestureRecognizer* longPressRecognizer =
       [[UILongPressGestureRecognizer alloc]