Commit 8c598600 authored by aboxhall's avatar aboxhall Committed by Commit bot

Revert of Disable many tests with flaky accessibility audits. (patchset #2...

Revert of Disable many tests with flaky accessibility audits. (patchset #2 id:20001 of https://codereview.chromium.org/2434473004/ )

Reason for revert:
This is done more efficiently by https://codereview.chromium.org/2436063002

Original issue's description:
> Disable many tests with flaky accessibility audits.
>
> BUG=657514
> TBR=stevenjb
>
> Committed: https://crrev.com/486e2998a18f28fa0a0afe8e1e485805fdc00be7
> Cr-Commit-Position: refs/heads/master@{#426325}

TBR=holte@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=657514

Review-Url: https://chromiumcodereview.appspot.com/2440973003
Cr-Commit-Position: refs/heads/master@{#426916}
parent 87d76a1b
......@@ -118,8 +118,7 @@ AdvancedSettingsWebUITest.prototype = {
};
// TODO(crbug.com/617066) Flakes on Win.
// TODO(crbug.com/657514) Flakes on linux and chromeos too.
GEN('#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)');
GEN('#if defined(OS_WIN)');
GEN('#define MAYBE_testAdvancedSettingsShown ' +
'DISABLED_testAdvancedSettingsShown');
GEN('#else');
......
......@@ -268,16 +268,8 @@ CertificateManagerSettingsWebUITest.prototype = {
browsePreload: CERTIFICATE_MANAGER_SETTINGS_PAGE_URL,
};
// TODO(crbug.com/657514) Flakes on linux and chromeos.
GEN('#if defined(OS_LINUX) || defined(OS_CHROMEOS)');
GEN('#define MAYBE_testViewAndDeleteCert ' +
'DISABLED_testViewAndDeleteCert');
GEN('#else');
GEN('#define MAYBE_testViewAndDeleteCert testViewAndDeleteCert');
GEN('#endif');
TEST_F('CertificateManagerSettingsWebUITest',
'MAYBE_testViewAndDeleteCert', function() {
'testViewAndDeleteCert', function() {
assertEquals(this.browsePreload, document.location.href);
this.mockHandler.expects(once()).viewCertificate(['c1']);
......
......@@ -60,13 +60,6 @@ EditDictionaryWebUITest.prototype = {
};
// Verify that users can add and remove words in the dictionary.
// TODO(crbug.com/657514) Flakes on linux and chromeos too.
GEN('#if defined(OS_LINUX) || defined(OS_CHROMEOS)');
GEN('#define MAYBE_testAddRemoveWords ' +
'DISABLED_testAddRemoveWords');
GEN('#else');
GEN('#define MAYBE_testAddRemoveWords testAddRemoveWords');
GEN('#endif');
TEST_F('EditDictionaryWebUITest', 'testAddRemoveWords', function() {
var testWord = 'foo';
$('language-dictionary-overlay-word-list').querySelector('input').value =
......@@ -121,14 +114,7 @@ TEST_F('EditDictionaryWebUITest', 'testNoCloseOnSearchEnter', function() {
// Verify that dictionary shows newly added words that arrived in a
// notification, but ignores duplicate add notifications.
// TODO(crbug.com/657514) Flakes on linux and chromeos.
GEN('#if defined(OS_LINUX) || defined(OS_CHROMEOS)');
GEN('#define MAYBE_testAddNotification ' +
'DISABLED_testAddNotification');
GEN('#else');
GEN('#define MAYBE_testAddNotification testAddNotification');
GEN('#endif');
TEST_F('EditDictionaryWebUITest', 'MAYBE_testAddNotification', function() {
TEST_F('EditDictionaryWebUITest', 'testAddNotification', function() {
// Begin with an empty dictionary.
EditDictionaryOverlay.setWordList([]);
expectEquals(1, EditDictionaryOverlay.getWordListForTesting().items.length);
......@@ -152,8 +138,7 @@ TEST_F('EditDictionaryWebUITest', 'MAYBE_testAddNotification', function() {
// Verify that dictionary hides newly removed words that arrived in a
// notification, but ignores duplicate remove notifications.
// TODO(crbug.com/631940): Flaky on Win 7.
// TODO(crbug.com/657514) Flakes on linux and chromeos too.
GEN('#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)');
GEN('#if defined(OS_WIN)');
GEN('#define MAYBE_testRemoveNotification DISABLED_testRemoveNotification');
GEN('#else');
GEN('#define MAYBE_testRemoveNotification testRemoveNotification');
......
......@@ -41,14 +41,8 @@ FontSettingsWebUITest.prototype = {
},
};
// TODO(crbug.com/657514) Flakes on linux and chromeos.
GEN('#if defined(OS_LINUX) || defined(OS_CHROMEOS)');
GEN('#define MAYBE_testOpenFontSettings DISABLED_testOpenFontSettings');
GEN('#else');
GEN('#define MAYBE_testOpenFontSettings testOpenFontSettings');
GEN('#endif // defined(OS_WIN)');
// Test opening font settings has correct location.
TEST_F('FontSettingsWebUITest', 'MAYBE_testOpenFontSettings', function() {
TEST_F('FontSettingsWebUITest', 'testOpenFontSettings', function() {
assertEquals(this.browsePreload, document.location.href);
});
......
......@@ -111,8 +111,7 @@ TEST_F('LanguagesOptionsDictionaryDownloadWebUITest',
// Verify that clicking the retry button calls the handler.
// This test is flaky on Windows. https://crbug.com/616791
// TODO(crbug.com/657514) Flakes on linux and chromeos too.
GEN('#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)');
GEN('#if defined(OS_WIN)');
GEN('#define MAYBE_testdictionaryDownloadRetry ' +
'DISABLED_testdictionaryDownloadRetry');
GEN('#else');
......
......@@ -191,13 +191,7 @@ MultilanguagePreferenceWebUIBrowserTest.prototype = {
};
// Make sure the case where no languages are selected is handled properly.
// TODO(crbug.com/657514) Flakes on linux and chromeos.
GEN('#if defined(OS_LINUX) || defined(OS_CHROMEOS)');
GEN('#define MAYBE_SelectFromBlank DISABLED_SelectFromBlank');
GEN('#else');
GEN('#define MAYBE_SelectFromBlank SelectFromBlank');
GEN('#endif // defined(OS_WIN)');
TEST_F('MultilanguagePreferenceWebUIBrowserTest', 'MAYBE_SelectFromBlank',
TEST_F('MultilanguagePreferenceWebUIBrowserTest', 'SelectFromBlank',
function() {
expectTrue($('language-options-list').selectLanguageByCode('fr'));
expectFalse($('spellcheck-language-checkbox').checked, 'fr');
......
......@@ -132,13 +132,7 @@ SettingsFormatWebUITest.prototype = {
/**
* Ensure that radio and checkbox buttons have consistent layout.
*/
// TODO(crbug.com/657514) Flakes on linux and chromeos.
GEN('#if defined(OS_LINUX) || defined(OS_CHROMEOS)');
GEN('#define MAYBE_RadioCheckboxStyleCheck DISABLED_RadioCheckboxStyleCheck');
GEN('#else');
GEN('#define MAYBE_RadioCheckboxStyleCheck RadioCheckboxStyleCheck');
GEN('#endif // defined(OS_WIN)');
TEST_F('SettingsFormatWebUITest', 'MAYBE_RadioCheckboxStyleCheck', function() {
TEST_F('SettingsFormatWebUITest', 'RadioCheckboxStyleCheck', function() {
var settings = $('settings');
assertTrue(settings != null, 'Unable to access settings');
var query = 'input[type=checkbox], input[type=radio]';
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment