Commit 8c81239d authored by Yuki Yamada's avatar Yuki Yamada Committed by Commit Bot

Sheriff: Disable CacheCounterTest.Empty on Win

This is a follow up for https://crrev.com/c/2557279 .
CacheCounterTest.Empty is flaky on Win too.

Bug: 971650
Change-Id: I856a44dc854eca2ab6fbed04fa0fbe5dc4b26bd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558081Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830924}
parent fe585a4c
...@@ -131,7 +131,7 @@ class CacheCounterTest : public InProcessBrowserTest { ...@@ -131,7 +131,7 @@ class CacheCounterTest : public InProcessBrowserTest {
// Tests that for the empty cache, the result is zero. // Tests that for the empty cache, the result is zero.
// Flaky. See crbug.com/971650. // Flaky. See crbug.com/971650.
#if defined(OS_LINUX) || defined(OS_CHROMEOS) #if defined(OS_LINUX) || defined(OS_CHROMEOS) || defined(OS_WIN)
#define MAYBE_Empty DISABLED_Empty #define MAYBE_Empty DISABLED_Empty
#else #else
#define MAYBE_Empty Empty #define MAYBE_Empty Empty
......
...@@ -240,14 +240,7 @@ class CacheCounterTest : public PlatformTest { ...@@ -240,14 +240,7 @@ class CacheCounterTest : public PlatformTest {
}; };
// Tests that for the empty cache, the result is zero. // Tests that for the empty cache, the result is zero.
// Disabled on Windows because this test randomly crashes on Win 7 Tests x64 TEST_F(CacheCounterTest, Empty) {
// (1). See: https://crbug.com/1152289
#if defined(OS_WIN)
#define MAYBE_Empty DISABLED_Empty
#else
#define MAYBE_Empty Empty
#endif
TEST_F(CacheCounterTest, MAYBE_Empty) {
CacheCounter counter(browser_state()); CacheCounter counter(browser_state());
counter.Init(prefs(), browsing_data::ClearBrowsingDataTab::ADVANCED, counter.Init(prefs(), browsing_data::ClearBrowsingDataTab::ADVANCED,
base::BindRepeating(&CacheCounterTest::CountingCallback, base::BindRepeating(&CacheCounterTest::CountingCallback,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment