Commit 8c97247e authored by Daniel Bratell's avatar Daniel Bratell Committed by Commit Bot

[jumbo] Merge two identical kFaviconsPerCategoryImage constants

In some jumbo build experiments (not official) there was an
identical constant in two explore_sites files. In jumbo builds
many cc files are merged into one translation unit for much
faster compilation.

This moves the constant to a header where it can be reused.

Change-Id: Id460645a39d69999bf2227c25651d1149f1a6d6c
Reviewed-on: https://chromium-review.googlesource.com/c/1275895
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: default avatarJustin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600172}
parent 29da00b9
...@@ -23,9 +23,6 @@ using chrome::android::explore_sites::ExploreSitesVariation; ...@@ -23,9 +23,6 @@ using chrome::android::explore_sites::ExploreSitesVariation;
using chrome::android::explore_sites::GetExploreSitesVariation; using chrome::android::explore_sites::GetExploreSitesVariation;
namespace explore_sites { namespace explore_sites {
namespace {
const int kFaviconsPerCategoryImage = 4;
}
ExploreSitesServiceImpl::ExploreSitesServiceImpl( ExploreSitesServiceImpl::ExploreSitesServiceImpl(
std::unique_ptr<ExploreSitesStore> store, std::unique_ptr<ExploreSitesStore> store,
......
...@@ -16,6 +16,8 @@ ...@@ -16,6 +16,8 @@
#include "url/gurl.h" #include "url/gurl.h"
namespace explore_sites { namespace explore_sites {
constexpr int kFaviconsPerCategoryImage = 4;
// The in-memory representation of a site in the ExploreSitesStore. // The in-memory representation of a site in the ExploreSitesStore.
// Image data is not represented here because it is requested separately from // Image data is not represented here because it is requested separately from
// the UI layer. // the UI layer.
......
...@@ -19,8 +19,6 @@ ...@@ -19,8 +19,6 @@
namespace explore_sites { namespace explore_sites {
namespace { namespace {
const int kFaviconsPerCategoryImage = 4;
// Ratio of icon size to the amount of padding between the icons. // Ratio of icon size to the amount of padding between the icons.
const int kIconPaddingScale = 8; const int kIconPaddingScale = 8;
} // namespace } // namespace
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment