Mark classes with final dtors as final

- -Wfinal-dtor-non-final-class warns on classes with final dtors but
  not final classes.
- Error messages are better when the class is marked final.
- Fix existing issues in code base and a follow up will remove warning
  exemption.

Bug: 999886
Test: no errors building
Change-Id: I1c7d6c834958298ff1b369f47be2efd2a8227338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508187Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827841}

third_party/blink/renderer/core/animation/css_clip_interpolation_type.cc

@@ -88,7 +88,7 @@ class InheritedClipChecker : public CSSInterpolationType::CSSConversionChecker {
   const Vector<Length> inherited_length_list_;
 };
 
-class CSSClipNonInterpolableValue : public NonInterpolableValue {
+class CSSClipNonInterpolableValue final : public NonInterpolableValue {
  public:
   ~CSSClipNonInterpolableValue() final = default;
 
@@ -121,7 +121,7 @@ struct DowncastTraits<CSSClipNonInterpolableValue> {
   }
 };
 
-class UnderlyingAutosChecker
+class UnderlyingAutosChecker final
     : public CSSInterpolationType::CSSConversionChecker {
  public:
   explicit UnderlyingAutosChecker(const ClipAutos& underlying_autos)

third_party/blink/renderer/core/animation/css_default_interpolation_type.h

@@ -11,7 +11,8 @@
 
 namespace blink {
 
-class CORE_EXPORT CSSDefaultNonInterpolableValue : public NonInterpolableValue {
+class CORE_EXPORT CSSDefaultNonInterpolableValue final
+    : public NonInterpolableValue {
  public:
   ~CSSDefaultNonInterpolableValue() final = default;
 

third_party/blink/renderer/core/animation/css_font_variation_settings_interpolation_type.cc

@@ -16,7 +16,7 @@
 
 namespace blink {
 
-class CSSFontVariationSettingsNonInterpolableValue
+class CSSFontVariationSettingsNonInterpolableValue final
     : public NonInterpolableValue {
  public:
   ~CSSFontVariationSettingsNonInterpolableValue() final = default;
@@ -65,7 +65,8 @@ static bool TagsMatch(const NonInterpolableValue& a,
   return GetTags(a) == GetTags(b);
 }
 
-class UnderlyingTagsChecker : public InterpolationType::ConversionChecker {
+class UnderlyingTagsChecker final
+    : public InterpolationType::ConversionChecker {
  public:
   explicit UnderlyingTagsChecker(const Vector<uint32_t>& tags) : tags_(tags) {}
   ~UnderlyingTagsChecker() final = default;
@@ -79,7 +80,7 @@ class UnderlyingTagsChecker : public InterpolationType::ConversionChecker {
   const Vector<uint32_t> tags_;
 };
 
-class InheritedFontVariationSettingsChecker
+class InheritedFontVariationSettingsChecker final
     : public CSSInterpolationType::CSSConversionChecker {
  public:
   explicit InheritedFontVariationSettingsChecker(

third_party/blink/renderer/core/animation/css_image_interpolation_type.cc

@@ -34,7 +34,7 @@ const StyleImage* GetStyleImage(const CSSProperty& property,
 }
 }  // namespace
 
-class CSSImageNonInterpolableValue : public NonInterpolableValue {
+class CSSImageNonInterpolableValue final : public NonInterpolableValue {
  public:
   ~CSSImageNonInterpolableValue() final = default;
 
@@ -165,7 +165,7 @@ bool CSSImageInterpolationType::EqualNonInterpolableValues(
       To<CSSImageNonInterpolableValue>(*b));
 }
 
-class UnderlyingImageChecker
+class UnderlyingImageChecker final
     : public CSSInterpolationType::CSSConversionChecker {
  public:
   UnderlyingImageChecker(const InterpolationValue& underlying)
@@ -203,7 +203,7 @@ InterpolationValue CSSImageInterpolationType::MaybeConvertInitial(
   return nullptr;
 }
 
-class InheritedImageChecker
+class InheritedImageChecker final
     : public CSSInterpolationType::CSSConversionChecker {
  public:
   InheritedImageChecker(const CSSProperty& property,

third_party/blink/renderer/core/animation/css_image_list_interpolation_type.cc

@@ -18,7 +18,7 @@
 
 namespace blink {
 
-class UnderlyingImageListChecker
+class UnderlyingImageListChecker final
     : public CSSInterpolationType::CSSConversionChecker {
  public:
   explicit UnderlyingImageListChecker(const InterpolationValue& underlying)
@@ -65,7 +65,7 @@ InterpolationValue CSSImageListInterpolationType::MaybeConvertStyleImageList(
       });
 }
 
-class InheritedImageListChecker
+class InheritedImageListChecker final
     : public CSSInterpolationType::CSSConversionChecker {
  public:
   InheritedImageListChecker(const CSSProperty& property,

third_party/blink/renderer/core/animation/css_length_list_interpolation_type.cc

@@ -65,7 +65,7 @@ InterpolationValue CSSLengthListInterpolationType::MaybeConvertInitial(
   return MaybeConvertLengthList(initial_length_list, 1);
 }
 
-class InheritedLengthListChecker
+class InheritedLengthListChecker final
     : public CSSInterpolationType::CSSConversionChecker {
  public:
   InheritedLengthListChecker(const CSSProperty& property,

third_party/blink/renderer/core/animation/css_scale_interpolation_type.cc

@@ -81,7 +81,7 @@ class InheritedScaleChecker
 
 }  // namespace
 
-class CSSScaleNonInterpolableValue : public NonInterpolableValue {
+class CSSScaleNonInterpolableValue final : public NonInterpolableValue {
  public:
   ~CSSScaleNonInterpolableValue() final = default;
 

third_party/blink/renderer/core/animation/css_size_list_interpolation_type.cc

@@ -18,7 +18,7 @@
 
 namespace blink {
 
-class UnderlyingSizeListChecker
+class UnderlyingSizeListChecker final
     : public CSSInterpolationType::CSSConversionChecker {
  public:
   explicit UnderlyingSizeListChecker(const NonInterpolableList& underlying_list)
@@ -47,7 +47,7 @@ class UnderlyingSizeListChecker
   scoped_refptr<const NonInterpolableList> underlying_list_;
 };
 
-class InheritedSizeListChecker
+class InheritedSizeListChecker final
     : public CSSInterpolationType::CSSConversionChecker {
  public:
   InheritedSizeListChecker(const CSSProperty& property,

third_party/blink/renderer/core/animation/css_visibility_interpolation_type.cc

@@ -13,7 +13,7 @@
 
 namespace blink {
 
-class CSSVisibilityNonInterpolableValue : public NonInterpolableValue {
+class CSSVisibilityNonInterpolableValue final : public NonInterpolableValue {
  public:
   ~CSSVisibilityNonInterpolableValue() final = default;
 
@@ -59,7 +59,7 @@ struct DowncastTraits<CSSVisibilityNonInterpolableValue> {
   }
 };
 
-class UnderlyingVisibilityChecker
+class UnderlyingVisibilityChecker final
     : public CSSInterpolationType::CSSConversionChecker {
  public:
   explicit UnderlyingVisibilityChecker(EVisibility visibility)

third_party/blink/renderer/core/animation/list_interpolation_functions.h

@@ -81,7 +81,7 @@ class CORE_EXPORT ListInterpolationFunctions {
                                             const NonInterpolableValue* b);
 };
 
-class CORE_EXPORT NonInterpolableList : public NonInterpolableValue {
+class CORE_EXPORT NonInterpolableList final : public NonInterpolableValue {
  public:
   ~NonInterpolableList() final = default;
 

third_party/blink/renderer/core/animation/path_interpolation_functions.cc

@@ -100,7 +100,7 @@ InterpolationValue PathInterpolationFunctions::ConvertValue(
                                 path_seg_types, style_path->GetWindRule()));
 }
 
-class UnderlyingPathSegTypesChecker
+class UnderlyingPathSegTypesChecker final
     : public InterpolationType::ConversionChecker {
  public:
   ~UnderlyingPathSegTypesChecker() final = default;

third_party/blink/renderer/core/frame/coop_access_violation_report_body.h

@@ -12,7 +12,8 @@
 
 namespace blink {
 
-class CORE_EXPORT CoopAccessViolationReportBody : public LocationReportBody {
+class CORE_EXPORT CoopAccessViolationReportBody final
+    : public LocationReportBody {
   DEFINE_WRAPPERTYPEINFO();
 
  public:

third_party/blink/renderer/modules/media/audio/audio_renderer_mixer_manager.h

@@ -40,7 +40,7 @@ namespace blink {
 //
 // There should only be one instance of AudioRendererMixerManager per render
 // thread.
-class BLINK_MODULES_EXPORT AudioRendererMixerManager
+class BLINK_MODULES_EXPORT AudioRendererMixerManager final
     : public media::AudioRendererMixerPool {
  public:
   ~AudioRendererMixerManager() final;

third_party/blink/renderer/modules/mediastream/local_media_stream_audio_source.h

@@ -22,7 +22,7 @@ class LocalFrame;
 // using the parameters and session ID found in MediaStreamDevice, just before
 // the first track is connected. Audio data is transported directly to the
 // tracks (i.e., there is no audio processing).
-class MODULES_EXPORT LocalMediaStreamAudioSource
+class MODULES_EXPORT LocalMediaStreamAudioSource final
     : public MediaStreamAudioSource,
       public media::AudioCapturerSource::CaptureCallback {
  public: