Commit 8cc988f4 authored by Hiroshige Hayashizaki's avatar Hiroshige Hayashizaki Committed by Commit Bot

Fix crbug link in the message for dynamic imports from service workers

Bug: 824647, 1020812
Change-Id: I76a39e2bf114eb080153952a7f9abc80a1696cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454555Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815499}
parent 3c9a7ffa
......@@ -50,8 +50,8 @@ bool WorkerModulatorImpl::IsDynamicImportForbidden(String* reason) {
// TODO(https://crbug.com/824647): Support module loading for Service Worker.
*reason =
"Module scripts are not supported on WorkerGlobalScope yet (see "
"https://crbug.com/680046).";
"Module scripts are not supported on ServiceWorkerGlobalScope yet (see "
"https://crbug.com/824647).";
return true;
}
......
This is a testharness.js-based test.
FAIL Non-object: null promise_test: Unhandled rejection with value: object "TypeError: Module scripts are not supported on WorkerGlobalScope yet (see https://crbug.com/680046)."
FAIL Non-object: true promise_test: Unhandled rejection with value: object "TypeError: Module scripts are not supported on WorkerGlobalScope yet (see https://crbug.com/680046)."
FAIL Non-object: false promise_test: Unhandled rejection with value: object "TypeError: Module scripts are not supported on WorkerGlobalScope yet (see https://crbug.com/680046)."
FAIL Non-object: string promise_test: Unhandled rejection with value: object "TypeError: Module scripts are not supported on WorkerGlobalScope yet (see https://crbug.com/680046)."
FAIL Non-object: array promise_test: Unhandled rejection with value: object "TypeError: Module scripts are not supported on WorkerGlobalScope yet (see https://crbug.com/680046)."
FAIL Non-object: null promise_test: Unhandled rejection with value: object "TypeError: Module scripts are not supported on ServiceWorkerGlobalScope yet (see https://crbug.com/824647)."
FAIL Non-object: true promise_test: Unhandled rejection with value: object "TypeError: Module scripts are not supported on ServiceWorkerGlobalScope yet (see https://crbug.com/824647)."
FAIL Non-object: false promise_test: Unhandled rejection with value: object "TypeError: Module scripts are not supported on ServiceWorkerGlobalScope yet (see https://crbug.com/824647)."
FAIL Non-object: string promise_test: Unhandled rejection with value: object "TypeError: Module scripts are not supported on ServiceWorkerGlobalScope yet (see https://crbug.com/824647)."
FAIL Non-object: array promise_test: Unhandled rejection with value: object "TypeError: Module scripts are not supported on ServiceWorkerGlobalScope yet (see https://crbug.com/824647)."
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS Static import.
PASS Nested static import.
FAIL Static import and then dynamic import. assert_array_equals: value is "Failed to do dynamic import: TypeError: Module scripts are not supported on WorkerGlobalScope yet (see https://crbug.com/680046).", expected array
FAIL Dynamic import. assert_array_equals: value is "Failed to do dynamic import: TypeError: Module scripts are not supported on WorkerGlobalScope yet (see https://crbug.com/680046).", expected array
FAIL Nested dynamic import. assert_array_equals: value is "Failed to do dynamic import: TypeError: Module scripts are not supported on WorkerGlobalScope yet (see https://crbug.com/680046).", expected array
FAIL Dynamic import and then static import. assert_array_equals: value is "Failed to do dynamic import: TypeError: Module scripts are not supported on WorkerGlobalScope yet (see https://crbug.com/680046).", expected array
FAIL eval(import()). assert_array_equals: value is "Failed to do dynamic import: TypeError: Module scripts are not supported on WorkerGlobalScope yet (see https://crbug.com/680046).", expected array
FAIL Static import and then dynamic import. assert_array_equals: value is "Failed to do dynamic import: TypeError: Module scripts are not supported on ServiceWorkerGlobalScope yet (see https://crbug.com/824647).", expected array
FAIL Dynamic import. assert_array_equals: value is "Failed to do dynamic import: TypeError: Module scripts are not supported on ServiceWorkerGlobalScope yet (see https://crbug.com/824647).", expected array
FAIL Nested dynamic import. assert_array_equals: value is "Failed to do dynamic import: TypeError: Module scripts are not supported on ServiceWorkerGlobalScope yet (see https://crbug.com/824647).", expected array
FAIL Dynamic import and then static import. assert_array_equals: value is "Failed to do dynamic import: TypeError: Module scripts are not supported on ServiceWorkerGlobalScope yet (see https://crbug.com/824647).", expected array
FAIL eval(import()). assert_array_equals: value is "Failed to do dynamic import: TypeError: Module scripts are not supported on ServiceWorkerGlobalScope yet (see https://crbug.com/824647).", expected array
Harness: the test ran to completion.
......@@ -23,8 +23,8 @@ promise_test(t => {
assert_equals(msg_event.data.name, 'TypeError');
assert_equals(
msg_event.data.message,
'Module scripts are not supported on WorkerGlobalScope yet ' +
'(see https://crbug.com/680046).');
'Module scripts are not supported on ServiceWorkerGlobalScope ' +
'yet (see https://crbug.com/824647).');
});
}, 'Dynamic import() on ServiceWorkerGlobalScope should reject the promise.');
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment