Commit 8cf13972 authored by Miriam Gershenson's avatar Miriam Gershenson Committed by Commit Bot

Revert "Enable "AsyncDns" feature by default on Android"

This reverts commit 0532f223.

Reason for revert: Full launch needs to be rolled back and retried in a future milestone due to a bug. The experiment cleanup here was premature.

Original change's description:
> Enable "AsyncDns" feature by default on Android
> 
> Also clean up Android-specific experiment code, but leave the
> base::Feature.
> 
> Bug: 768874
> Change-Id: Ic7b81a878e3e81bc1a5c2c2fae242df23c5387ca
> Reviewed-on: https://chromium-review.googlesource.com/868077
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529866}

TBR=isherman@chromium.org,mgersh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 768874, 805020
Change-Id: Ib67c727aef748b4e80714e6128c3bfbdc24d3544
Reviewed-on: https://chromium-review.googlesource.com/881206Reviewed-by: default avatarMiriam Gershenson <mgersh@chromium.org>
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531381}
parent 4a372788
...@@ -3518,6 +3518,12 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -3518,6 +3518,12 @@ const FeatureEntry kFeatureEntries[] = {
kSpeculativePreconnectFeatureVariations, kSpeculativePreconnectFeatureVariations,
"SpeculativePreconnectValidation")}, "SpeculativePreconnectValidation")},
#if defined(OS_ANDROID)
{"enable-async-dns", flag_descriptions::kAsyncDnsName,
flag_descriptions::kAsyncDnsDescription, kOsAndroid,
FEATURE_VALUE_TYPE(features::kAsyncDns)},
#endif // defined(OS_ANDROID)
{"enable-overflow-icons-for-media-controls", {"enable-overflow-icons-for-media-controls",
flag_descriptions::kOverflowIconsForMediaControlsName, flag_descriptions::kOverflowIconsForMediaControlsName,
flag_descriptions::kOverflowIconsForMediaControlsDescription, kOsAll, flag_descriptions::kOverflowIconsForMediaControlsDescription, kOsAll,
......
...@@ -1683,6 +1683,9 @@ const char kAndroidViewPasswordsName[] = "Copy and view passwords for Android"; ...@@ -1683,6 +1683,9 @@ const char kAndroidViewPasswordsName[] = "Copy and view passwords for Android";
const char kAndroidViewPasswordsDescription[] = const char kAndroidViewPasswordsDescription[] =
"Enables copying and viewing passwords in settings."; "Enables copying and viewing passwords in settings.";
const char kAsyncDnsName[] = "Async DNS resolver";
const char kAsyncDnsDescription[] = "Enables the built-in DNS resolver.";
const char kAutofillAccessoryViewName[] = const char kAutofillAccessoryViewName[] =
"Autofill suggestions as keyboard accessory view"; "Autofill suggestions as keyboard accessory view";
const char kAutofillAccessoryViewDescription[] = const char kAutofillAccessoryViewDescription[] =
......
...@@ -1035,6 +1035,9 @@ extern const char kAndroidPaymentAppsDescription[]; ...@@ -1035,6 +1035,9 @@ extern const char kAndroidPaymentAppsDescription[];
extern const char kAndroidViewPasswordsName[]; extern const char kAndroidViewPasswordsName[];
extern const char kAndroidViewPasswordsDescription[]; extern const char kAndroidViewPasswordsDescription[];
extern const char kAsyncDnsName[];
extern const char kAsyncDnsDescription[];
extern const char kAutofillAccessoryViewName[]; extern const char kAutofillAccessoryViewName[];
extern const char kAutofillAccessoryViewDescription[]; extern const char kAutofillAccessoryViewDescription[];
......
...@@ -71,7 +71,7 @@ const base::Feature kAssetDownloadSuggestionsFeature{ ...@@ -71,7 +71,7 @@ const base::Feature kAssetDownloadSuggestionsFeature{
// Enables the built-in DNS resolver. // Enables the built-in DNS resolver.
const base::Feature kAsyncDns { const base::Feature kAsyncDns {
"AsyncDns", "AsyncDns",
#if defined(OS_CHROMEOS) || defined(OS_MACOSX) || defined(OS_ANDROID) #if defined(OS_CHROMEOS) || defined(OS_MACOSX)
base::FEATURE_ENABLED_BY_DEFAULT base::FEATURE_ENABLED_BY_DEFAULT
#else #else
base::FEATURE_DISABLED_BY_DEFAULT base::FEATURE_DISABLED_BY_DEFAULT
......
...@@ -372,6 +372,21 @@ ...@@ -372,6 +372,21 @@
] ]
} }
], ],
"AsyncDns": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"AsyncDns"
]
}
]
}
],
"AutofillCreditCardBankNameDisplay": [ "AutofillCreditCardBankNameDisplay": [
{ {
"platforms": [ "platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment