Commit 8d0418a4 authored by thakis@chromium.org's avatar thakis@chromium.org

Fix DCHECK caused by Task Manager assuming all requests have a render view.

BUG=69883
TEST=Display Task Manager while one or more tabs are open, and start typing into the Omnibox of one of them.

Review URL: http://codereview.chromium.org/6240006
Patch from Wez Weatherall <wez@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71807 0039d316-1c4b-4281-b951-d872f2087c98
parent 7674115b
...@@ -891,7 +891,13 @@ void TaskManagerModel::OnBytesRead(net::URLRequestJob* job, const char* buf, ...@@ -891,7 +891,13 @@ void TaskManagerModel::OnBytesRead(net::URLRequestJob* job, const char* buf,
if (!ResourceDispatcherHost::RenderViewForRequest(job->request(), if (!ResourceDispatcherHost::RenderViewForRequest(job->request(),
&render_process_host_child_id, &render_process_host_child_id,
&routing_id)) { &routing_id)) {
NOTREACHED(); // Only net::URLRequestJob instances created by the ResourceDispatcherHost
// have a render view associated. Jobs from components such as the
// SearchProvider for autocomplete, have no associated view, so we can't
// correctly attribute the bandwidth they consume.
// TODO(wez): All jobs' resources should ideally be accountable, even if
// only by contributing to the Browser process' stats.
return;
} }
// This happens in the IO thread, post it to the UI thread. // This happens in the IO thread, post it to the UI thread.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment