Commit 8d29cdc0 authored by Xiaocheng Hu's avatar Xiaocheng Hu Committed by Commit Bot

Cleanup some TODO(crbug.com/825895)

NoTry: True
Tbr: eae@chromium.org, futhark@chromium.org
Bug: 825895
Change-Id: I4b483d2960c216f4dd99a38d3004b9ac9a1df3d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833907Reviewed-by: default avatarXiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701627}
parent 2ccba5b4
...@@ -46,7 +46,6 @@ class CSSNumericLiteralValue; ...@@ -46,7 +46,6 @@ class CSSNumericLiteralValue;
// The order of this enum should not change since its elements are used as // The order of this enum should not change since its elements are used as
// indices in the addSubtractResult matrix. // indices in the addSubtractResult matrix.
// TODO(crbug.com/825895): Change it to |enum class CSSMathExpressionCategory|.
enum CalculationCategory { enum CalculationCategory {
kCalcNumber = 0, kCalcNumber = 0,
kCalcLength, kCalcLength,
......
...@@ -79,7 +79,7 @@ CSSMathExpressionNode* CSSMathMax::ToCalcExpressionNode() const { ...@@ -79,7 +79,7 @@ CSSMathExpressionNode* CSSMathMax::ToCalcExpressionNode() const {
for (const auto& value : NumericValues()) { for (const auto& value : NumericValues()) {
CSSMathExpressionNode* operand = value->ToCalcExpressionNode(); CSSMathExpressionNode* operand = value->ToCalcExpressionNode();
if (!operand) { if (!operand) {
// TODO(crbug.com/825895): Remove this when all ToCalcExpressionNode() // TODO(crbug.com/983784): Remove this when all ToCalcExpressionNode()
// overrides are implemented. // overrides are implemented.
NOTREACHED(); NOTREACHED();
continue; continue;
...@@ -87,7 +87,7 @@ CSSMathExpressionNode* CSSMathMax::ToCalcExpressionNode() const { ...@@ -87,7 +87,7 @@ CSSMathExpressionNode* CSSMathMax::ToCalcExpressionNode() const {
operands.push_back(value->ToCalcExpressionNode()); operands.push_back(value->ToCalcExpressionNode());
} }
if (!operands.size()) { if (!operands.size()) {
// TODO(crbug.com/825895): Remove this when all ToCalcExpressionNode() // TODO(crbug.com/983784): Remove this when all ToCalcExpressionNode()
// overrides are implemented. // overrides are implemented.
NOTREACHED(); NOTREACHED();
return nullptr; return nullptr;
......
...@@ -78,7 +78,7 @@ CSSMathExpressionNode* CSSMathMin::ToCalcExpressionNode() const { ...@@ -78,7 +78,7 @@ CSSMathExpressionNode* CSSMathMin::ToCalcExpressionNode() const {
for (const auto& value : NumericValues()) { for (const auto& value : NumericValues()) {
CSSMathExpressionNode* operand = value->ToCalcExpressionNode(); CSSMathExpressionNode* operand = value->ToCalcExpressionNode();
if (!operand) { if (!operand) {
// TODO(crbug.com/825895): Remove this when all ToCalcExpressionNode() // TODO(crbug.com/983784): Remove this when all ToCalcExpressionNode()
// overrides are implemented. // overrides are implemented.
NOTREACHED(); NOTREACHED();
continue; continue;
...@@ -86,7 +86,7 @@ CSSMathExpressionNode* CSSMathMin::ToCalcExpressionNode() const { ...@@ -86,7 +86,7 @@ CSSMathExpressionNode* CSSMathMin::ToCalcExpressionNode() const {
operands.push_back(value->ToCalcExpressionNode()); operands.push_back(value->ToCalcExpressionNode());
} }
if (!operands.size()) { if (!operands.size()) {
// TODO(crbug.com/825895): Remove this when all ToCalcExpressionNode() // TODO(crbug.com/983784): Remove this when all ToCalcExpressionNode()
// overrides are implemented. // overrides are implemented.
NOTREACHED(); NOTREACHED();
return nullptr; return nullptr;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment