media: Fix UMA reporting on EME new session failure
Currently in NewSessionCdmResultPromise::reject(), we missed the |key_system_uma_prefix_| when reporting UMA. As a result, all failure cases are reported to a wrong UMA name. For the record, the bug was first introduced in: https://codereview.chromium.org/2691673002/ This CL is manually tested as follows: 1. Update ClearKeyCdm::CreateSessionAndGenerateRequest() to unconditionally reject the promise with system code 111. 2. Build browser_test and run the following: out/Debug/browser_tests --gtest_filter=MSE_ExternalClearKey*Playback_VideoOnly_MP4_VP9/0 -v=1 where -v=1 will print out all histograms at the end. 3. Made sure we have the following: Histogram: Media.EME.Unknown.GenerateRequest recorded 1 samples, mean = 2.0 (flags = 0x41) 0 ... 2 ------------------------------------------O (1 = 100.0%) {0.0%} 3 ... Histogram: Media.EME.Unknown.GenerateRequest.SystemCode recorded 1 samples (flags = 0x41) 111 -----------------------------------------------O (1 = 100.0%) Bug: 690722 Test: See above Change-Id: I81a81a7e8a0e650494209dc1c7dd0e6d950d8353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747045 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#686194}
Showing
Please register or sign in to comment