Disable TwoTabsCrashOneReloadsOneLeaves on Android due to flaky DCHECKs.
Before this CL, random tests in the RenderFrameHostManagerTestWithSiteIsolation test suite would flakily fail when calling content::Compositor::Initialize from RenderFrameHostManagerTestWithSiteIsolation::SetUp: Check failed: !CompositorImpl::IsInitialized(). Because of the above, the CL removes the call to CompositorImpl::IsInitialized and disables the TwoTabsCrashOneReloadsOneLeaves testcase, because the disabled test case fails without such call - it hits another DCHECK - one in RenderWidgetHostViewChildFrame::SetFrameConnectorDelegate: about |parent_view->GetFrameSinkId().is_valid()|. The CL doesn't simply move the call to CompositorImpl::IsInitialized into the single test case that needs it, because of concerns about the first flaky DCHECK (the one about |!CompositorImpl::IsInitialized()|). Bug: 1067432 Change-Id: Ib1febb7252b4628573f64c7971b917a261aef24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135900 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#756475}
Showing
Please register or sign in to comment