Deprecate the hspace/vspace attributes on table

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/l3rZbX-BUaM/3iSlHsjmW0wJ

BUG=277080
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/421263002

git-svn-id: svn://svn.chromium.org/blink/trunk@179142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/platform/linux/fast/table/table-hspace-align-center-expected.txt

+CONSOLE WARNING: The 'hspace' attribute on table is deprecated. Please use CSS instead.
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600

third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug1261-expected.txt

+CONSOLE WARNING: The 'hspace' attribute on table is deprecated. Please use CSS instead.
+CONSOLE WARNING: The 'vspace' attribute on table is deprecated. Please use CSS instead.
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600

third_party/WebKit/LayoutTests/platform/mac/fast/table/table-hspace-align-center-expected.txt

+CONSOLE WARNING: The 'hspace' attribute on table is deprecated. Please use CSS instead.
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600

third_party/WebKit/LayoutTests/platform/win-xp/fast/table/table-hspace-align-center-expected.txt

+CONSOLE WARNING: The 'hspace' attribute on table is deprecated. Please use CSS instead.
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600

third_party/WebKit/LayoutTests/platform/win-xp/tables/mozilla/bugs/bug1261-expected.txt

+CONSOLE WARNING: The 'hspace' attribute on table is deprecated. Please use CSS instead.
+CONSOLE WARNING: The 'vspace' attribute on table is deprecated. Please use CSS instead.
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600

third_party/WebKit/LayoutTests/platform/win/fast/table/table-hspace-align-center-expected.txt

+CONSOLE WARNING: The 'hspace' attribute on table is deprecated. Please use CSS instead.
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600

third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug1261-expected.txt

+CONSOLE WARNING: The 'hspace' attribute on table is deprecated. Please use CSS instead.
+CONSOLE WARNING: The 'vspace' attribute on table is deprecated. Please use CSS instead.
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600

third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug1261-expected.txt

+CONSOLE WARNING: The 'hspace' attribute on table is deprecated. Please use CSS instead.
+CONSOLE WARNING: The 'vspace' attribute on table is deprecated. Please use CSS instead.
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600

third_party/WebKit/Source/core/frame/UseCounter.cpp

@@ -778,6 +778,12 @@ String UseCounter::deprecationMessage(Feature feature)
     case WebSocketURL:
         return "'WebSocket.URL' is deprecated. Please use 'WebSocket.url' instead.";
 
+    case HTMLTableElementVspace:
+        return "The 'vspace' attribute on table is deprecated. Please use CSS instead.";
+
+    case HTMLTableElementHspace:
+        return "The 'hspace' attribute on table is deprecated. Please use CSS instead.";
+
     // Features that aren't deprecated don't have a deprecation message.
     default:
         return String();

third_party/WebKit/Source/core/html/HTMLTableElement.cpp

@@ -321,11 +321,11 @@ void HTMLTableElement::collectStyleForPresentationAttribute(const QualifiedName&
         if (!value.isEmpty())
             addHTMLLengthToStyle(style, CSSPropertyBorderSpacing, value);
     } else if (name == vspaceAttr) {
-        UseCounter::count(document(), UseCounter::HTMLTableElementVspace);
+        UseCounter::countDeprecation(document(), UseCounter::HTMLTableElementVspace);
         addHTMLLengthToStyle(style, CSSPropertyMarginTop, value);
         addHTMLLengthToStyle(style, CSSPropertyMarginBottom, value);
     } else if (name == hspaceAttr) {
-        UseCounter::count(document(), UseCounter::HTMLTableElementHspace);
+        UseCounter::countDeprecation(document(), UseCounter::HTMLTableElementHspace);
         addHTMLLengthToStyle(style, CSSPropertyMarginLeft, value);
         addHTMLLengthToStyle(style, CSSPropertyMarginRight, value);
     } else if (name == alignAttr) {