Commit 8d3be030 authored by Mario Sanchez Prada's avatar Mario Sanchez Prada Committed by Commit Bot

Migrate ServiceWorkerScriptCacheMap methods to net::CompletionOnceCallback

Replace usage of net::CompletionCallback and update callers.

Bug: 807724
Change-Id: I90f180fa481ea20e5e67aaab08f27e421342ca39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524045
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641133}
parent 08282975
...@@ -4,6 +4,8 @@ ...@@ -4,6 +4,8 @@
#include "content/browser/service_worker/service_worker_script_cache_map.h" #include "content/browser/service_worker/service_worker_script_cache_map.h"
#include <utility>
#include "base/bind.h" #include "base/bind.h"
#include "base/logging.h" #include "base/logging.h"
#include "content/browser/service_worker/service_worker_context_core.h" #include "content/browser/service_worker/service_worker_context_core.h"
...@@ -90,16 +92,16 @@ void ServiceWorkerScriptCacheMap::SetResources( ...@@ -90,16 +92,16 @@ void ServiceWorkerScriptCacheMap::SetResources(
void ServiceWorkerScriptCacheMap::WriteMetadata( void ServiceWorkerScriptCacheMap::WriteMetadata(
const GURL& url, const GURL& url,
const std::vector<uint8_t>& data, const std::vector<uint8_t>& data,
const net::CompletionCallback& callback) { net::CompletionOnceCallback callback) {
if (!context_) { if (!context_) {
callback.Run(net::ERR_ABORTED); std::move(callback).Run(net::ERR_ABORTED);
return; return;
} }
auto found = resource_map_.find(url); auto found = resource_map_.find(url);
if (found == resource_map_.end() || if (found == resource_map_.end() ||
found->second.resource_id == kInvalidServiceWorkerResourceId) { found->second.resource_id == kInvalidServiceWorkerResourceId) {
callback.Run(net::ERR_FILE_NOT_FOUND); std::move(callback).Run(net::ERR_FILE_NOT_FOUND);
return; return;
} }
...@@ -114,20 +116,21 @@ void ServiceWorkerScriptCacheMap::WriteMetadata( ...@@ -114,20 +116,21 @@ void ServiceWorkerScriptCacheMap::WriteMetadata(
raw_writer->WriteMetadata( raw_writer->WriteMetadata(
buffer.get(), data.size(), buffer.get(), data.size(),
base::BindOnce(&ServiceWorkerScriptCacheMap::OnMetadataWritten, base::BindOnce(&ServiceWorkerScriptCacheMap::OnMetadataWritten,
weak_factory_.GetWeakPtr(), std::move(writer), callback)); weak_factory_.GetWeakPtr(), std::move(writer),
std::move(callback)));
} }
void ServiceWorkerScriptCacheMap::ClearMetadata( void ServiceWorkerScriptCacheMap::ClearMetadata(
const GURL& url, const GURL& url,
const net::CompletionCallback& callback) { net::CompletionOnceCallback callback) {
WriteMetadata(url, std::vector<uint8_t>(), callback); WriteMetadata(url, std::vector<uint8_t>(), std::move(callback));
} }
void ServiceWorkerScriptCacheMap::OnMetadataWritten( void ServiceWorkerScriptCacheMap::OnMetadataWritten(
std::unique_ptr<ServiceWorkerResponseMetadataWriter> writer, std::unique_ptr<ServiceWorkerResponseMetadataWriter> writer,
const net::CompletionCallback& callback, net::CompletionOnceCallback callback,
int result) { int result) {
callback.Run(result); std::move(callback).Run(result);
} }
} // namespace content } // namespace content
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
#include "base/memory/weak_ptr.h" #include "base/memory/weak_ptr.h"
#include "content/browser/service_worker/service_worker_database.h" #include "content/browser/service_worker/service_worker_database.h"
#include "content/common/content_export.h" #include "content/common/content_export.h"
#include "net/base/completion_callback.h" #include "net/base/completion_once_callback.h"
#include "net/url_request/url_request_status.h" #include "net/url_request/url_request_status.h"
class GURL; class GURL;
...@@ -51,9 +51,9 @@ class CONTENT_EXPORT ServiceWorkerScriptCacheMap { ...@@ -51,9 +51,9 @@ class CONTENT_EXPORT ServiceWorkerScriptCacheMap {
// Writes the metadata of the existing script. // Writes the metadata of the existing script.
void WriteMetadata(const GURL& url, void WriteMetadata(const GURL& url,
const std::vector<uint8_t>& data, const std::vector<uint8_t>& data,
const net::CompletionCallback& callback); net::CompletionOnceCallback callback);
// Clears the metadata of the existing script. // Clears the metadata of the existing script.
void ClearMetadata(const GURL& url, const net::CompletionCallback& callback); void ClearMetadata(const GURL& url, net::CompletionOnceCallback callback);
size_t size() const { return resource_map_.size(); } size_t size() const { return resource_map_.size(); }
...@@ -81,7 +81,7 @@ class CONTENT_EXPORT ServiceWorkerScriptCacheMap { ...@@ -81,7 +81,7 @@ class CONTENT_EXPORT ServiceWorkerScriptCacheMap {
void OnMetadataWritten( void OnMetadataWritten(
std::unique_ptr<ServiceWorkerResponseMetadataWriter> writer, std::unique_ptr<ServiceWorkerResponseMetadataWriter> writer,
const net::CompletionCallback& callback, net::CompletionOnceCallback callback,
int result); int result);
ServiceWorkerVersion* owner_; ServiceWorkerVersion* owner_;
......
...@@ -1059,8 +1059,8 @@ void ServiceWorkerVersion::SetCachedMetadata(const GURL& url, ...@@ -1059,8 +1059,8 @@ void ServiceWorkerVersion::SetCachedMetadata(const GURL& url,
callback_id, "URL", url.spec()); callback_id, "URL", url.spec());
script_cache_map_.WriteMetadata( script_cache_map_.WriteMetadata(
url, data, url, data,
base::Bind(&ServiceWorkerVersion::OnSetCachedMetadataFinished, base::BindOnce(&ServiceWorkerVersion::OnSetCachedMetadataFinished,
weak_factory_.GetWeakPtr(), callback_id, data.size())); weak_factory_.GetWeakPtr(), callback_id, data.size()));
} }
void ServiceWorkerVersion::ClearCachedMetadata(const GURL& url) { void ServiceWorkerVersion::ClearCachedMetadata(const GURL& url) {
...@@ -1069,8 +1069,8 @@ void ServiceWorkerVersion::ClearCachedMetadata(const GURL& url) { ...@@ -1069,8 +1069,8 @@ void ServiceWorkerVersion::ClearCachedMetadata(const GURL& url) {
"ServiceWorkerVersion::ClearCachedMetadata", "ServiceWorkerVersion::ClearCachedMetadata",
callback_id, "URL", url.spec()); callback_id, "URL", url.spec());
script_cache_map_.ClearMetadata( script_cache_map_.ClearMetadata(
url, base::Bind(&ServiceWorkerVersion::OnClearCachedMetadataFinished, url, base::BindOnce(&ServiceWorkerVersion::OnClearCachedMetadataFinished,
weak_factory_.GetWeakPtr(), callback_id)); weak_factory_.GetWeakPtr(), callback_id));
} }
void ServiceWorkerVersion::ClaimClients(ClaimClientsCallback callback) { void ServiceWorkerVersion::ClaimClients(ClaimClientsCallback callback) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment