Commit 8d50ec99 authored by John Z Wu's avatar John Z Wu Committed by Commit Bot

Fix incorrect delegate call in CWVAutofillController

Update password was calling the save password delegate method.
Accidentally introduced in:
https://chromium-review.googlesource.com/c/chromium/src/+/2315252

Change-Id: I5779831c37aa24f383940abbfb534e1b618ec9f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439018
Auto-Submit: John Wu <jzw@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: default avatarHiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811920}
parent e680566d
...@@ -629,18 +629,18 @@ showUnmaskPromptForCard:(const autofill::CreditCard&)creditCard ...@@ -629,18 +629,18 @@ showUnmaskPromptForCard:(const autofill::CreditCard&)creditCard
CWVPassword* password = CWVPassword* password =
[[CWVPassword alloc] initWithPasswordForm:credentials]; [[CWVPassword alloc] initWithPasswordForm:credentials];
[self.delegate [self.delegate autofillController:self
autofillController:self decideUpdatePolicyForPassword:password
decideSavePolicyForPassword:password decisionHandler:^(CWVPasswordUserDecision decision) {
decisionHandler:^(CWVPasswordUserDecision decision) { // Marking a password update as "never" makes no sense as
// Marking a password update as "never" makes no sense as // the password has already been saved.
// the password has already been saved. DCHECK_NE(decision, CWVPasswordUserDecisionNever)
DCHECK_NE(decision, CWVPasswordUserDecisionNever) << "A password update can only be accepted or "
<< "A password update can only be accepted or ignored."; "ignored.";
if (decision == CWVPasswordUserDecisionYes) { if (decision == CWVPasswordUserDecisionYes) {
formPtr->Update(credentials); formPtr->Update(credentials);
} }
}]; }];
} }
- (void)removePasswordInfoBarManualFallback:(BOOL)manual { - (void)removePasswordInfoBarManualFallback:(BOOL)manual {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment