Skip to content

GitLab

T
tangled
Commit 8d6d5225 authored by kylechar's avatar kylechar Committed by Commit Bot
Browse files
Options

RELAND: Add viz_screenshot_sync_tests. 

Add a new GPU test target that runs screenshot_sync a second time with
--enable-features=VizDisplayCompositor. This test will verify that GPU
compositing is working for OOP-D. The test only runs on Windows and
Linux bots.

Originally landed in https://crrev.com/c/1028613 but was reverted
because it failed on Windows 7 waterfall bots. There is some bug in the
interaction between the passthrough command decoder, OOP-D and frame
capture. Disable viz_screenshot_sync on Windows 7 FYI bots for now.

Bug: 812385, 825906
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I96ad1b49313bf5bbcdca0f464da4b185ee74722a
Reviewed-on: https://chromium-review.googlesource.com/1047146
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558443}
parent 2886f545
Hide whitespace changes
Inline Side-by-side
Showing with 362 additions and 1 deletion
content/test/gpu/generate_buildbot_json.py
View file @ 8d6d5225
......@@ -272,7 +272,7 @@ FYI_WATERFALL = {
'GPU FYI Linux Builder (dbg)' : {},
'GPU FYI Linux Ozone Builder' : {},
'GPU FYI Linux dEQP Builder' : {},
},
},
'testers': {
'Win7 FYI Release (NVIDIA)': {
......@@ -2437,6 +2437,36 @@ TELEMETRY_GPU_INTEGRATION_TESTS = {
'shards': 20,
},
},
'viz_screenshot_sync': {
'target_name': 'screenshot_sync',
'args': [
'--dont-restore-color-profile-after-test',
],
'extra_browser_args': [
# This test confirms that GPU compositing is working with OOP-D.
'--enable-features=VizDisplayCompositor',
],
'tester_configs': [
{
'predicate': Predicates.DEFAULT,
'disabled_instrumentation_types': ['tsan'],
'os_types': ['win', 'linux'],
},
],
'disabled_tester_configs': [
{
'names': [
'Linux FYI Ozone (Intel)',
# TODO(crbug.com/825906): Enable test on Win7 FYI bots when OOP-D +
# passthrough command decoder bug is fixed.
'Win7 FYI Release (NVIDIA)',
'Win7 FYI Release (AMD)',
'Win7 FYI Debug (AMD)',
'Win7 FYI x64 Release (NVIDIA)',
],
},
],
},
}
# These isolated tests don't use telemetry. They need to be placed in the
......
testing/buildbot/chromium.gpu.fyi.json
View file @ 8d6d5225
......@@ -3388,6 +3388,32 @@
]
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=debug",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3-384.90",
"os": "Ubuntu",
"pool": "Chrome-GPU"
}
]
}
},
{
"args": [
"webgl_conformance",
......@@ -4001,6 +4027,33 @@
"expiration": 10800
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "1002:6613",
"os": "Ubuntu",
"pool": "Chrome-GPU"
}
],
"expiration": 10800
}
},
{
"args": [
"webgl_conformance",
......@@ -4485,6 +4538,32 @@
]
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "8086:5912",
"os": "Ubuntu",
"pool": "Chrome-GPU"
}
]
}
},
{
"args": [
"webgl_conformance",
......@@ -4984,6 +5063,32 @@
]
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3-384.90",
"os": "Ubuntu",
"pool": "Chrome-GPU"
}
]
}
},
{
"args": [
"webgl_conformance",
......@@ -12473,6 +12578,32 @@
]
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=debug",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3-23.21.13.8816",
"os": "Windows-10",
"pool": "Chrome-GPU"
}
]
}
},
{
"args": [
"webgl_conformance",
......@@ -13130,6 +13261,32 @@
]
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "8086:5912-24.20.100.6025",
"os": "Windows-10",
"pool": "Chrome-GPU"
}
]
}
},
{
"args": [
"webgl_conformance",
......@@ -13868,6 +14025,32 @@
]
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "8086:5912-23.20.16.4877",
"os": "Windows-10",
"pool": "Chrome-GPU"
}
]
}
},
{
"args": [
"webgl_conformance",
......@@ -14919,6 +15102,41 @@
"script": "//testing/trigger_scripts/trigger_multiple_dimensions.py"
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3-23.21.13.8816",
"os": "Windows-10",
"pool": "Chrome-GPU"
}
]
},
"trigger_script": {
"args": [
"--multiple-trigger-configs",
"[{\"gpu\": \"10de:1cb3-23.21.13.8816\", \"os\": \"Windows-10\", \"pool\": \"Chrome-GPU\"}]",
"--multiple-dimension-script-verbose",
"True"
],
"script": "//testing/trigger_scripts/trigger_multiple_dimensions.py"
}
},
{
"args": [
"webgl_conformance",
......
testing/buildbot/chromium.gpu.json
View file @ 8d6d5225
......@@ -634,6 +634,32 @@
]
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=debug",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3-384.90",
"os": "Ubuntu",
"pool": "Chrome-GPU"
}
]
}
},
{
"args": [
"webgl_conformance",
......@@ -995,6 +1021,32 @@
]
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3-384.90",
"os": "Ubuntu",
"pool": "Chrome-GPU"
}
]
}
},
{
"args": [
"webgl_conformance",
......@@ -2784,6 +2836,32 @@
]
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=debug",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3-23.21.13.8816",
"os": "Windows-10",
"pool": "Chrome-GPU"
}
]
}
},
{
"args": [
"webgl_conformance",
......@@ -3348,6 +3426,41 @@
"script": "//testing/trigger_scripts/trigger_multiple_dimensions.py"
}
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=VizDisplayCompositor",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"name": "viz_screenshot_sync_tests",
"override_compile_targets": [
"telemetry_gpu_integration_test"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3-23.21.13.8816",
"os": "Windows-10",
"pool": "Chrome-GPU"
}
]
},
"trigger_script": {
"args": [
"--multiple-trigger-configs",
"[{\"gpu\": \"10de:1cb3-23.21.13.8816\", \"os\": \"Windows-10\", \"pool\": \"Chrome-GPU\"}]",
"--multiple-dimension-script-verbose",
"True"
],
"script": "//testing/trigger_scripts/trigger_multiple_dimensions.py"
}
},
{
"args": [
"webgl_conformance",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment