Commit 8d7ec26a authored by Tommy Li's avatar Tommy Li Committed by Commit Bot

[omnibox] Add GOC Variations to about:flags

Adds all three shown header variations, as well as the default-hidden
header variation, for a total of 4.

I'm doing this because Android users, and our off-corp tester team
cannot use the Google Experimental Web interface.

Bug: 1106096
Change-Id: Ie87ea1c36afc3983dc8221d5ef7c695a54e6c60a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422473Reviewed-by: default avatarJustin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809401}
parent d4e2ed79
...@@ -1219,6 +1219,14 @@ const FeatureEntry::FeatureVariation kOmniboxOnFocusSuggestionsVariations[] = { ...@@ -1219,6 +1219,14 @@ const FeatureEntry::FeatureVariation kOmniboxOnFocusSuggestionsVariations[] = {
#endif // defined(OS_ANDROID) #endif // defined(OS_ANDROID)
}; };
const FeatureEntry::FeatureVariation
kOmniboxOnFocusSuggestionsContextualWebVariations[] = {
{"GOC Only", {}, 0, "t3317583"},
{"GOC, pSuggest Fallback", {}, 0, "t3317692"},
{"GOC, pSuggest Backfill", {}, 0, "t3317694"},
{"GOC, Default Hidden", {}, 0, "t3317834"},
};
const FeatureEntry::FeatureVariation kMaxZeroSuggestMatchesVariations[] = { const FeatureEntry::FeatureVariation kMaxZeroSuggestMatchesVariations[] = {
{ {
"5", "5",
...@@ -3737,7 +3745,11 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -3737,7 +3745,11 @@ const FeatureEntry kFeatureEntries[] = {
{"omnibox-on-focus-suggestions-contextual-web", {"omnibox-on-focus-suggestions-contextual-web",
flag_descriptions::kOmniboxOnFocusSuggestionsContextualWebName, flag_descriptions::kOmniboxOnFocusSuggestionsContextualWebName,
flag_descriptions::kOmniboxOnFocusSuggestionsContextualWebDescription, flag_descriptions::kOmniboxOnFocusSuggestionsContextualWebDescription,
kOsAll, FEATURE_VALUE_TYPE(omnibox::kOnFocusSuggestionsContextualWeb)}, kOsAll,
FEATURE_WITH_PARAMS_VALUE_TYPE(
omnibox::kOnFocusSuggestionsContextualWeb,
kOmniboxOnFocusSuggestionsContextualWebVariations,
"OmniboxGoogleOnContent")},
{"omnibox-local-zero-suggest-frecency-ranking", {"omnibox-local-zero-suggest-frecency-ranking",
flag_descriptions::kOmniboxLocalZeroSuggestFrecencyRankingName, flag_descriptions::kOmniboxLocalZeroSuggestFrecencyRankingName,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment