Adding a feature and a flag for renderer IDs usage in iOS autofill.

Created a feature and a flag to experiment with using numeric renderer
IDs instead of string form and field identifiers in Autofill filling
logic.

Bug: 1075444, 1131038
Change-Id: I8a3110d3271028d5a347dbea21c6031274955e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418331
Commit-Queue: Maria Kazinova <kazinova@google.com>
Reviewed-by: Matthias Körber <koerber@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809400}

chrome/browser/flag-metadata.json

@@ -391,6 +391,11 @@
     "owners": [ "fhorschig" ],
     "expiry_milestone": 87
   },
+  {
+    "name": "autofill-use-renderer-ids",
+    "owners": [ "kazinova" ],
+    "expiry_milestone": 91
+  },
   {
     "name": "avatar-toolbar-button",
     "owners": [ "droger", "my-chrome-everywhere@google.com" ],

components/autofill/core/common/autofill_features.cc

@@ -362,5 +362,13 @@ bool IsAutofillCreditCardAssistEnabled() {
 #endif
 }
 
+#if defined(OS_IOS)
+// Controls whether or not autofill uses numeric renderer IDs instead of string
+// form and field identifiers in filling logic.
+// TODO(crbug/1131038): Remove once it's launched.
+const base::Feature kAutofillUseUniqueRendererIDsOnIOS{
+    "AutofillUseUniqueRendererIDsOnIOS", base::FEATURE_DISABLED_BY_DEFAULT};
+#endif
+
 }  // namespace features
 }  // namespace autofill

components/autofill/core/common/autofill_features.h

@@ -102,6 +102,10 @@ bool IsAutofillCreditCardAssistEnabled();
 bool IsMacViewsAutofillPopupExperimentEnabled();
 #endif  // defined(OS_APPLE)
 
+#if defined(OS_IOS)
+extern const base::Feature kAutofillUseUniqueRendererIDsOnIOS;
+#endif  // OS_IOS
+
 }  // namespace features
 }  // namespace autofill
 

ios/chrome/browser/flags/about_flags.mm

@@ -689,6 +689,11 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
     {"modern-tab-strip", flag_descriptions::kModernTabStripName,
      flag_descriptions::kModernTabStripDescription, flags_ui::kOsIos,
      FEATURE_VALUE_TYPE(kModernTabStrip)},
+    {"autofill-use-renderer-ids",
+     flag_descriptions::kAutofillUseRendererIDsName,
+     flag_descriptions::kAutofillUseRendererIDsDescription, flags_ui::kOsIos,
+     FEATURE_VALUE_TYPE(
+         autofill::features::kAutofillUseUniqueRendererIDsOnIOS)},
 };
 
 bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {

ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc

@@ -126,6 +126,12 @@ const char kAutofillUseMobileLabelDisambiguationDescription[] =
     "When enabled, Autofill suggestions' labels are displayed using a "
     "mobile-friendly format.";
 
+const char kAutofillUseRendererIDsName[] =
+    "Autofill logic uses unqiue renderer IDs";
+const char kAutofillUseRendererIDsDescription[] =
+    "When enabled, Autofill logic uses unique numeric renderer IDs instead "
+    "of string form and field identifiers in form filling logic.";
+
 const char kBlockPopupInfobarMessagesUIName[] =
     "Block Popup Infobars Messages UI";
 const char kBlockPopupInfobarMessagesUIDescription[] =

ios/chrome/browser/flags/ios_chrome_flag_descriptions.h

@@ -96,6 +96,12 @@ extern const char kAutofillRichMetadataQueriesDescription[];
 extern const char kAutofillUseMobileLabelDisambiguationName[];
 extern const char kAutofillUseMobileLabelDisambiguationDescription[];
 
+// Title and description for the flag that controls whether Autofill's
+// logic is using numeric unique renderer IDs instead of string IDs for
+// form and field elements.
+extern const char kAutofillUseRendererIDsName[];
+extern const char kAutofillUseRendererIDsDescription[];
+
 // Title and description for the flag that enables Messages UI on
 // Block Popup Infobars.
 extern const char kBlockPopupInfobarMessagesUIName[];