Flip the feature flag for disallowing wildcards patterns in flash to enabled by default

Bug: 1073883, 1103143
Change-Id: Ib4121c2fea110ae13f490faffeb113a609e6b81e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279796Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786235}

chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

@@ -205,7 +205,7 @@ TEST_F(PolicyProviderTest, ResourceIdentifier) {
       profile.GetTestingPrefService();
 
   auto value = std::make_unique<base::ListValue>();
-  value->AppendString("[*.]google.com");
+  value->AppendString("http://mail.google.com:80");
   prefs->SetManagedPref(prefs::kManagedPluginsAllowedForUrls, std::move(value));
 
   PolicyProvider provider(prefs);

chrome/browser/extensions/api/content_settings/content_settings_apitest.cc

@@ -96,7 +96,7 @@ class ExtensionContentSettingsApiTest : public ExtensionApiTest {
         map->GetContentSetting(example_url, example_url,
                                ContentSettingsType::JAVASCRIPT, std::string()));
     EXPECT_EQ(
-        CONTENT_SETTING_ALLOW,
+        CONTENT_SETTING_BLOCK,
         map->GetContentSetting(example_url, example_url,
                                ContentSettingsType::PLUGINS, std::string()));
     EXPECT_EQ(
@@ -141,7 +141,7 @@ class ExtensionContentSettingsApiTest : public ExtensionApiTest {
     EXPECT_EQ(CONTENT_SETTING_BLOCK,
               map->GetContentSetting(url, url, ContentSettingsType::JAVASCRIPT,
                                      std::string()));
-    EXPECT_EQ(CONTENT_SETTING_DETECT_IMPORTANT_CONTENT,
+    EXPECT_EQ(CONTENT_SETTING_BLOCK,
               map->GetContentSetting(url, url, ContentSettingsType::PLUGINS,
                                      std::string()));
     EXPECT_EQ(CONTENT_SETTING_ALLOW,

chrome/test/data/extensions/api_test/content_settings/incognitoisolation/test.js

@@ -19,7 +19,6 @@ var settings = [
   'cookies',
   'images',
   'javascript',
-  'plugins',
   'popups',
   'location',
   'notifications',

chrome/test/data/extensions/api_test/content_settings/standard/test.js

@@ -26,7 +26,7 @@ var settings = {
   "cookies": "block",
   "images": "allow",
   "javascript": "block",
-  "plugins": "detect_important_content",
+  "plugins": "block", // <all_urls> exception can't be defined for plugins
   "popups": "allow",
   "location": "block",
   "notifications": "block",

components/content_settings/core/common/features.cc

@@ -24,6 +24,6 @@ const base::Feature kImprovedCookieControlsForThirdPartyCookieBlocking{
 
 const base::Feature kDisallowWildcardsInPluginContentSettings{
     "DisallowWildcardsInPluginContentSettings",
-    base::FEATURE_DISABLED_BY_DEFAULT};
+    base::FEATURE_ENABLED_BY_DEFAULT};
 
 }  // namespace content_settings
\ No newline at end of file