Commit 8da2e8e2 authored by sigbjornf's avatar sigbjornf Committed by Commit bot

Promptly let go of WebURLLoader objects.

The objects keeping their own WebURLLoaders (and thus being
WebURLLoaderClients) must promptly let go of their ownership upon
becoming garbage. Not doing so risks the embedder calling the client
while it is in a sweepable state.

R=
BUG=568173

Review URL: https://codereview.chromium.org/1635113002

Cr-Commit-Position: refs/heads/master@{#371639}
parent 2e3b092d
...@@ -51,6 +51,9 @@ public: ...@@ -51,6 +51,9 @@ public:
~ResourceLoader() override; ~ResourceLoader() override;
DECLARE_TRACE(); DECLARE_TRACE();
// Promptly release m_loader.
EAGERLY_FINALIZE();
void start(); void start();
void changeToSynchronous(); void changeToSynchronous();
......
...@@ -75,6 +75,9 @@ public: ...@@ -75,6 +75,9 @@ public:
DECLARE_VIRTUAL_TRACE(); DECLARE_VIRTUAL_TRACE();
// Promptly finalize m_loader.
EAGERLY_FINALIZE();
protected: protected:
PingLoader(LocalFrame*, ResourceRequest&, const FetchInitiatorInfo&, StoredCredentials); PingLoader(LocalFrame*, ResourceRequest&, const FetchInitiatorInfo&, StoredCredentials);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment