Commit 8db438f7 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Move a chrome/common/url_constants.h entry into the right section.

Add a note at the bottom of the file to let developers know where to put
entries.

Change-Id: I4201fb4526a6f9bb8354043b05ccd425aa0e8b1d
Reviewed-on: https://chromium-review.googlesource.com/1054442
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: default avatarAlexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557767}
parent 22b0d42c
......@@ -276,6 +276,9 @@ const char kOnlineEulaURLPath[] =
const char kTPMFirmwareUpdateLearnMoreURL[] =
"https://support.google.com/chromebook/?p=tpm_update";
const char kTimeZoneSettingsLearnMoreURL[] =
"https://support.google.com/chromebook/answer/177871?hl=%s";
#endif // defined(OS_CHROMEOS)
#if defined(OS_MACOSX)
......@@ -307,9 +310,4 @@ const char kOutdatedPluginLearnMoreURL[] =
"https://support.google.com/chrome/?p=ib_outdated_plugin";
#endif
#if defined(OS_CHROMEOS)
const char kTimeZoneSettingsLearnMoreURL[] =
"https://support.google.com/chromebook/answer/177871?hl=%s";
#endif
} // namespace chrome
......@@ -6,10 +6,12 @@
// Except for WebUI UI/Host/SubPage constants. Those go in
// chrome/common/webui_url_constants.h.
//
// - The constants are divided into sections: Cross platform, platform-specific,
// and feature-specific.
// - When adding platform/feature specific constants, if there already exists an
// appropriate #if block, use that.
// - Keep the constants sorted by name within its section.
// - Use the same order in this header and url_constants.cc.
// - Keep the constants sorted by name.
// - Put platform/feature specific constants towards the end in the appropriate
// section.
#ifndef CHROME_COMMON_URL_CONSTANTS_H_
#define CHROME_COMMON_URL_CONSTANTS_H_
......@@ -227,6 +229,9 @@ extern const char kOnlineEulaURLPath[];
// The URL for the "learn more" link for TPM firmware update.
extern const char kTPMFirmwareUpdateLearnMoreURL[];
// The URL for the "Learn more" page for the time zone settings page.
extern const char kTimeZoneSettingsLearnMoreURL[];
#endif // defined(OS_CHROMEOS)
#if defined(OS_MACOSX)
......@@ -258,10 +263,7 @@ extern const char kBlockedPluginLearnMoreURL[];
extern const char kOutdatedPluginLearnMoreURL[];
#endif
#if defined(OS_CHROMEOS)
// The URL for the "Learn more" page for the time zone settings page.
extern const char kTimeZoneSettingsLearnMoreURL[];
#endif
// Please do not append entries here. See the comments at the top of the file.
} // namespace chrome
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment