PDF Viewer update: Hide sidenav icons when only one tab exists.

Bug: 1119945
Change-Id: I888b739114e838a223cdfae39eead1578783a5fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374666
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803278}

chrome/browser/resources/pdf/elements/viewer-pdf-sidenav.html

@@ -41,14 +41,13 @@
     border-color: var(--sidenav-selected-tab-color);
   }
 </style>
-<div id="icons">
+<div id="icons" hidden$="[[!bookmarks.length]]">
   <div class$="button-wrapper [[thumbnailButtonClass_(thumbnailView_)]]">
     <cr-icon-button iron-icon="pdf:thumbnails" role="tab"
         title="$i18n{tooltipThumbnails}" on-click="onThumbnailClick_">
     </cr-icon-button>
   </div>
-  <div class$="button-wrapper [[outlineButtonClass_(thumbnailView_)]]"
-      hidden$="[[!bookmarks.length]]">
+  <div class$="button-wrapper [[outlineButtonClass_(thumbnailView_)]]">
     <cr-icon-button iron-icon="pdf:doc-outline" role="tab"
         title="$i18n{tooltipDocumentOutline}" on-click="onOutlineClick_">
     </cr-icon-button>

chrome/test/data/pdf/viewer_pdf_sidenav_test.js

@@ -22,6 +22,13 @@ const tests = [
    */
   function testViewToggle() {
     const sidenav = createSidenav();
+
+    // Add some dummy bookmarks so that the tabs selectors appear.
+    sidenav.bookmarks = [
+      {title: 'Foo', page: 1},
+      {title: 'Bar', page: 2},
+    ];
+
     const content = sidenav.shadowRoot.querySelector('#content');
     const buttons = /** @type {!NodeList<!CrIconButtonElement>} */ (
         sidenav.shadowRoot.querySelectorAll('cr-icon-button'));
@@ -36,16 +43,6 @@ const tests = [
     // Sidebar starts on thumbnail view.
     chrome.test.assertTrue(
         buttons[0].parentNode.classList.contains('selected'));
-
-    // Outline button is hidden since there are no bookmarks.
-    chrome.test.assertTrue(buttons[1].parentNode.hidden);
-
-    // Add some dummy bookmarks so that the button appears.
-    sidenav.bookmarks = [
-      {title: 'Foo', page: 1},
-      {title: 'Bar', page: 2},
-    ];
-    chrome.test.assertFalse(buttons[1].parentNode.hidden);
     chrome.test.assertFalse(
         buttons[1].parentNode.classList.contains('selected'));
     chrome.test.assertFalse(thumbnailBar.hidden);
@@ -71,6 +68,23 @@ const tests = [
 
     chrome.test.succeed();
   },
+
+  function testTabIconsHidden() {
+    const sidenav = createSidenav();
+    const buttonsContainer = sidenav.shadowRoot.querySelector('#icons');
+
+    chrome.test.assertEq(0, sidenav.bookmarks.length);
+    chrome.test.assertTrue(buttonsContainer.hidden);
+
+    // Add dummy bookmarks so that the buttons appear.
+    sidenav.bookmarks = [
+      {title: 'Foo', page: 1},
+      {title: 'Bar', page: 2},
+    ];
+
+    chrome.test.assertFalse(buttonsContainer.hidden);
+    chrome.test.succeed();
+  }
 ];
 
 chrome.test.runTests(tests);