Commit 8de03272 authored by Jamie Madill's avatar Jamie Madill Committed by Commit Bot

Switch angle_perftests to standalone.

This will not have a speed up but will allow ANGLE to complete
the transition to the standalone test runner. Also increase the
sharding parameter for these tests. Right now they only run on
Android.

Bug: angleproject:5124
Bug: 1140626
Change-Id: I61847aa30e0b00226e5961b78bc29cac52c659e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489723
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: default avatarYuly Novikov <ynovikov@chromium.org>
Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819551}
parent 89d8dc5f
This diff is collapsed.
......@@ -1576,6 +1576,11 @@
"script": "//third_party/angle/scripts/run_gtest_angle_test.py",
"type": "script",
},
"standalone_angle_perftests": {
"label": "//third_party/angle/src/tests:standalone_angle_perftests",
"script": "//testing/scripts/run_performance_tests.py",
"type": "script",
},
"standalone_angle_unittests": {
"label": "//third_party/angle/src/tests:standalone_angle_unittests",
"script": "//third_party/angle/scripts/run_gtest_angle_test.py",
......
......@@ -74,14 +74,6 @@
},
},
},
'angle_perftests': {
'remove_from': [
'Android FYI Release (Nexus 5)', # crbug.com/915429
'Android FYI Release (Nexus 6)', # anglebug.com/2433
'Android FYI Release (Nexus 6P)', # anglebug.com/4909
'Linux FYI GPU TSAN Release', # crbug.com/950542
],
},
'blink_platform_unittests': {
'modifications': {
# TODO(crbug.com/1108121): Remove this filter
......@@ -2526,6 +2518,14 @@
'Linux FYI Debug (NVIDIA)',
],
},
'standalone_angle_perftests': {
'remove_from': [
'Android FYI Release (Nexus 5)', # crbug.com/915429
'Android FYI Release (Nexus 6)', # anglebug.com/2433
'Android FYI Release (Nexus 6P)', # anglebug.com/4909
'Linux FYI GPU TSAN Release', # crbug.com/950542
],
},
'standalone_angle_unittests': {
'remove_from': [
# On Android, these are already run on the main waterfall.
......
......@@ -2019,19 +2019,28 @@
# Actually uploads results to the perf dashboard
'gpu_angle_perf_isolated_scripts': {
'angle_perftests': {
'standalone_angle_perftests': {
'args': [
'standalone_angle_perftests',
'--non-telemetry=true',
'--gtest-benchmark-name=angle_perftests',
'-v',
'--test-timeout=100',
],
'android_args': [
'--test-launcher-batch-limit=1',
],
'desktop_args': [
'--batch-size=1',
'--bot-mode',
'--max-processes=1',
'--print-test-stdout',
],
'merge': {
'script': '//tools/perf/process_perf_results.py',
},
'android_swarming': {
'shards': 4,
'shards': 6,
},
},
},
......@@ -2039,16 +2048,25 @@
# The angle perf tests should eventually be run on every platform
# ANGLE supports. Currently they run on Windows, Linux and Android.
'gpu_angle_perf_smoke_isolated_scripts': {
'angle_perftests': {
'standalone_angle_perftests': {
'args': [
'standalone_angle_perftests',
'--non-telemetry=true',
'--gtest-benchmark-name=angle_perftests',
'-v',
# Tell the tests to exit after one frame for faster iteration.
'--one-frame-only',
'--test-timeout=100',
],
'android_args': [
'--test-launcher-batch-limit=1',
],
'desktop_args': [
'--batch-size=1',
'--bot-mode',
'--max-processes=1',
'--print-test-stdout',
],
'merge': {
'script': '//tools/perf/process_perf_results.py',
# Does not upload to the perf dashboard
......@@ -2057,7 +2075,7 @@
],
},
'android_swarming': {
'shards': 3,
'shards': 6,
},
},
},
......
......@@ -105,6 +105,8 @@ GTEST_CONVERSION_WHITELIST = [
'net_perftests',
'browser_tests',
'services_perftests',
# TODO(jmadill): Remove once migrated. http://anglebug.com/5124
'standalone_angle_perftests',
'sync_performance_tests',
'tracing_perftests',
'views_perftests',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment