Remove app_crash_browsertest.cc.

This is effectively a revert of https://codereview.chromium.org/50073003
This was originally added to cover a crash in GTK, which is no longer
used. These days, other app window tests will also wait for the app
window to finish loading.

The hidden-window plus normal-window case has been added to
platform_apps/window_api.

BUG=469249

Review URL: https://codereview.chromium.org/1024373002

Cr-Commit-Position: refs/heads/master@{#321937}

chrome/browser/apps/app_crash_browsertest.cc

-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/apps/app_browsertest_util.h"
-#include "extensions/test/extension_test_message_listener.h"
-
-// This class of BrowserTests is a helper to create tests related to crashes in
-// Chrome Apps. To be tested, the app will have to be placed as any other test
-// app (see PlatformAppBrowserTest) and will need to send a "Done" message back.
-// When the "Done" message is received, the test succeed. If it is not, it is
-// assumed that Chrome has crashed and the test will anyway fail.
-//
-// The entry in this file should be something like:
-// IN_PROC_BROWSER_TEST_F(AppCrashTest, <TEST_NAME>) {
-//   ASSERT_TRUE(RunAppCrashTest("<DIRECTORY_TEST_NAME>"));
-// }
-
-class AppCrashTest : public extensions::PlatformAppBrowserTest {
-public:
- void RunAppCrashTest(const char* name) {
-   LoadAndLaunchPlatformApp(name, "Done");
-  }
-};
-
-// Disabling flaky test on ASAN,  crbug.com/469249
-#if !defined(ADDRESS_SANITIZER)
-IN_PROC_BROWSER_TEST_F(AppCrashTest, HiddenWindows) {
-  RunAppCrashTest("crashtest_hidden_windows");
-}
-#endif

chrome/chrome_tests.gypi

@@ -52,7 +52,6 @@
       'browser/accessibility/browser_accessibility_state_browsertest.cc',
       'browser/app_controller_mac_browsertest.mm',
       'browser/apps/app_browsertest.cc',
-      'browser/apps/app_crash_browsertest.cc',
       'browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm',
       'browser/apps/app_shim/test/app_shim_host_manager_test_api_mac.cc',
       'browser/apps/app_shim/test/app_shim_host_manager_test_api_mac.h',

chrome/test/data/extensions/platform_apps/crashtest_hidden_windows/manifest.json

-{
-  "name" : "Apps Crash Tests - Hidden Windows",
-  "version" : "0.1",
-  "app": {
-    "background": {
-      "scripts": ["test.js"]
-    }
-  }
-}

chrome/test/data/extensions/platform_apps/crashtest_hidden_windows/test.js

-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-chrome.app.runtime.onLaunched.addListener(function() {
-  chrome.app.window.create(
-    'index.html', { width: 800, height: 600, hidden: true },
-    function() {
-      chrome.app.window.create(
-        'index.html', { width: 800, height: 600, hidden: false },
-        function() {
-          chrome.test.sendMessage("Done");
-        }
-      );
-    }
-  );
-});

chrome/test/data/extensions/platform_apps/window_api/test.js

@@ -254,6 +254,19 @@ function testCreate() {
           win2.contentWindow.close();
         }));
       }));
+    },
+
+    function hiddenAndNormal() {
+      chrome.app.window.create('test.html',
+                               {hidden: true},
+                               callbackPass(function(win1) {
+        chrome.app.window.create('test.html',
+                                 {hidden: false},
+                                 callbackPass(function(win2) {
+          win1.contentWindow.close();
+          win2.contentWindow.close();
+        }));
+      }));
     }
   ]);
 }