Commit 8de77e39 authored by Glen Robertson's avatar Glen Robertson Committed by Chromium LUCI CQ

Stop recording HostedAppLaunchContainer for WebApp installs.

Same info is recorded as BookmarkAppLaunchContainer (which should be
renamed, crbug.com/1014328).
HostedAppLaunchContainer is still used for Hosted Apps.

Bug: 1160812
Change-Id: Id77df80d16f3d85a6161a224700a5fbd0765e8d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612286
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840896}
parent cd70a89b
...@@ -116,13 +116,13 @@ void ExpectTotalCounts(const base::HistogramTester& tester, ...@@ -116,13 +116,13 @@ void ExpectTotalCounts(const base::HistogramTester& tester,
void ExpectLaunchCounts(const base::HistogramTester& tester, void ExpectLaunchCounts(const base::HistogramTester& tester,
base::HistogramBase::Count windowLaunches, base::HistogramBase::Count windowLaunches,
base::HistogramBase::Count tabLaunches) { base::HistogramBase::Count tabLaunches) {
tester.ExpectBucketCount("Extensions.HostedAppLaunchContainer", tester.ExpectBucketCount("Extensions.BookmarkAppLaunchContainer",
apps::mojom::LaunchContainer::kLaunchContainerWindow, apps::mojom::LaunchContainer::kLaunchContainerWindow,
windowLaunches); windowLaunches);
tester.ExpectBucketCount("Extensions.HostedAppLaunchContainer", tester.ExpectBucketCount("Extensions.BookmarkAppLaunchContainer",
apps::mojom::LaunchContainer::kLaunchContainerTab, apps::mojom::LaunchContainer::kLaunchContainerTab,
tabLaunches); tabLaunches);
tester.ExpectTotalCount("Extensions.HostedAppLaunchContainer", tester.ExpectTotalCount("Extensions.BookmarkAppLaunchContainer",
windowLaunches + tabLaunches); windowLaunches + tabLaunches);
if (tabLaunches > 0) { if (tabLaunches > 0) {
......
...@@ -236,9 +236,6 @@ content::WebContents* WebAppLaunchManager::OpenApplication( ...@@ -236,9 +236,6 @@ content::WebContents* WebAppLaunchManager::OpenApplication(
browser->window()->Show(); browser->window()->Show();
// TODO(crbug.com/1014328): Populate WebApp metrics instead of Extensions. // TODO(crbug.com/1014328): Populate WebApp metrics instead of Extensions.
UMA_HISTOGRAM_ENUMERATION("Extensions.HostedAppLaunchContainer",
params.container);
if (params.container == apps::mojom::LaunchContainer::kLaunchContainerTab) { if (params.container == apps::mojom::LaunchContainer::kLaunchContainerTab) {
UMA_HISTOGRAM_ENUMERATION("Extensions.AppTabLaunchType", UMA_HISTOGRAM_ENUMERATION("Extensions.AppTabLaunchType",
extensions::LAUNCH_TYPE_REGULAR, 100); extensions::LAUNCH_TYPE_REGULAR, 100);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment