Commit 8e0f2eff authored by Adam Langley's avatar Adam Langley Committed by Commit Bot

webauthn: add some additional caBLE logging.

For now it's useful to be able to see the newly added status feedback in
the logcat for debugging. This uses LOG(ERROR) because I think that INFO
gets stripped from some official builds.

BUG=1002262

Change-Id: I91e6597ff848f1f48cb70c160a6642fd78ac789e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530834
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: default avatarMartin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#826044}
parent 50f6af21
...@@ -237,6 +237,7 @@ class AndroidPlatform : public device::cablev2::authenticator::Platform { ...@@ -237,6 +237,7 @@ class AndroidPlatform : public device::cablev2::authenticator::Platform {
void OnStatus(Status status) override { void OnStatus(Status status) override {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
LOG(ERROR) << __func__ << " " << static_cast<int>(status);
if (!cable_authenticator_) { if (!cable_authenticator_) {
return; return;
...@@ -247,6 +248,9 @@ class AndroidPlatform : public device::cablev2::authenticator::Platform { ...@@ -247,6 +248,9 @@ class AndroidPlatform : public device::cablev2::authenticator::Platform {
} }
void OnCompleted(base::Optional<Error> maybe_error) override { void OnCompleted(base::Optional<Error> maybe_error) override {
LOG(ERROR) << __func__ << " "
<< (maybe_error ? static_cast<int>(*maybe_error) : -1);
// The transaction might fail before interactive mode, thus // The transaction might fail before interactive mode, thus
// |cable_authenticator_| may be empty. // |cable_authenticator_| may be empty.
if (cable_authenticator_) { if (cable_authenticator_) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment