Commit 8e146ee7 authored by bttk's avatar bttk Committed by Commit Bot

LocationBar no longer needs to extend UrlBar.UrlBarDelegate

Bug: 1139481
Change-Id: Iff40d93d02e6e35aaf6573ecb1a60b582a263c9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500529
Commit-Queue: who/bttk <bttk@chromium.org>
Reviewed-by: default avatarPatrick Noland <pnoland@chromium.org>
Reviewed-by: default avatarFilip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821458}
parent c3ac65b0
...@@ -623,7 +623,7 @@ public class CustomTabToolbar extends ToolbarLayout implements View.OnLongClickL ...@@ -623,7 +623,7 @@ public class CustomTabToolbar extends ToolbarLayout implements View.OnLongClickL
/** /**
* Custom tab-specific implementation of the LocationBar interface. * Custom tab-specific implementation of the LocationBar interface.
*/ */
private class CustomTabLocationBar implements LocationBar { private class CustomTabLocationBar implements LocationBar, UrlBar.UrlBarDelegate {
private ToolbarDataProvider mToolbarDataProvider; private ToolbarDataProvider mToolbarDataProvider;
public CustomTabLocationBar(ToolbarDataProvider toolbarDataProvider) { public CustomTabLocationBar(ToolbarDataProvider toolbarDataProvider) {
......
...@@ -12,13 +12,12 @@ import androidx.annotation.Nullable; ...@@ -12,13 +12,12 @@ import androidx.annotation.Nullable;
import org.chromium.chrome.browser.lifecycle.Destroyable; import org.chromium.chrome.browser.lifecycle.Destroyable;
import org.chromium.chrome.browser.ntp.FakeboxDelegate; import org.chromium.chrome.browser.ntp.FakeboxDelegate;
import org.chromium.chrome.browser.ntp.NewTabPage; import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.omnibox.UrlBar.UrlBarDelegate;
import org.chromium.chrome.browser.tab.Tab; import org.chromium.chrome.browser.tab.Tab;
/** /**
* Container that holds the {@link UrlBar} and SSL state related with the current {@link Tab}. * Container that holds the {@link UrlBar} and SSL state related with the current {@link Tab}.
*/ */
public interface LocationBar extends UrlBarDelegate, Destroyable { public interface LocationBar extends Destroyable {
/** Handle all necessary tasks that can be delayed until initialization completes. */ /** Handle all necessary tasks that can be delayed until initialization completes. */
default void onDeferredStartup() {} default void onDeferredStartup() {}
......
...@@ -39,7 +39,8 @@ import java.util.List; ...@@ -39,7 +39,8 @@ import java.util.List;
* *
* <p>The coordinator creates and owns elements within this component. * <p>The coordinator creates and owns elements within this component.
*/ */
public final class LocationBarCoordinator implements LocationBar, FakeboxDelegate { public final class LocationBarCoordinator
implements LocationBar, FakeboxDelegate, UrlBar.UrlBarDelegate {
/** Identifies coordinators with methods specific to a device type. */ /** Identifies coordinators with methods specific to a device type. */
public interface SubCoordinator extends Destroyable {} public interface SubCoordinator extends Destroyable {}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment