Commit 8e177eff authored by Caleb Rouleau's avatar Caleb Rouleau

[Perf Waterfall] Pass correct abridged benchmark arg.

https://chromium-review.googlesource.com/c/catapult/+/1896356
changed the default so that now you need to pass in
--run-abridged-story-set or else the full story set will run.

Bug: 965158
Change-Id: I4453359f2bea160200c47befd118894d239a4634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935787
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719392}
parent 5724290f
......@@ -318,8 +318,8 @@ class TelemetryCommandGenerator(object):
if 'end' in self._story_selection_config:
selection_args.append('--story-shard-end-index=%d' % (
self._story_selection_config['end']))
if not self._story_selection_config.get('abridged', True):
selection_args.append('--run-full-story-set')
if self._story_selection_config.get('abridged', True):
selection_args.append('--run-abridged-story-set')
return selection_args
def _generate_reference_build_args(self):
......
......@@ -314,7 +314,7 @@ class ScriptsSmokeTest(unittest.TestCase):
command = run_performance_tests.TelemetryCommandGenerator(
'fake_benchmark_name', options, story_selection_config).generate(
'fake_output_dir')
self.assertIn('--run-full-story-set', command)
self.assertNotIn('--run-abridged-story-set', command)
self.assertIn('--story-shard-begin-index=1', command)
self.assertIn('--story-shard-end-index=5', command)
......@@ -330,7 +330,7 @@ class ScriptsSmokeTest(unittest.TestCase):
command = run_performance_tests.TelemetryCommandGenerator(
'fake_benchmark_name', options, story_selection_config).generate(
'fake_output_dir')
self.assertNotIn('--run-full-story-set', command)
self.assertIn('--run-abridged-story-set', command)
def testRunPerformanceTestsGtestArgsParser(self):
options = run_performance_tests.parse_arguments([
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment