Commit 8e22478d authored by mad's avatar mad Committed by Commit bot

Don't close SRT bubble on deactivate.

TBR=noelutz
OWNER of chrome/browser/safe_browsing folder,
for trivial change of returning false instead of base class' true.
Being exercised already by other derived classes, e.g., ExtensionDisabledGlobalError

We will want to merge this to M39 once it gets added to Canary, hopefully tomorrow...
BUG=419049

Review URL: https://codereview.chromium.org/616143002

Cr-Commit-Position: refs/heads/master@{#297518}
parent 77a493ce
...@@ -107,6 +107,10 @@ void SRTGlobalError::BubbleViewCancelButtonPressed(Browser* browser) { ...@@ -107,6 +107,10 @@ void SRTGlobalError::BubbleViewCancelButtonPressed(Browser* browser) {
DismissGlobalError(); DismissGlobalError();
} }
bool SRTGlobalError::ShouldCloseOnDeactivate() const {
return false;
}
void SRTGlobalError::DismissGlobalError() { void SRTGlobalError::DismissGlobalError() {
global_error_service_->RemoveGlobalError(this); global_error_service_->RemoveGlobalError(this);
delete this; delete this;
......
...@@ -38,6 +38,7 @@ class SRTGlobalError : public GlobalErrorWithStandardBubble, ...@@ -38,6 +38,7 @@ class SRTGlobalError : public GlobalErrorWithStandardBubble,
virtual void OnBubbleViewDidClose(Browser* browser) OVERRIDE; virtual void OnBubbleViewDidClose(Browser* browser) OVERRIDE;
virtual void BubbleViewAcceptButtonPressed(Browser* browser) OVERRIDE; virtual void BubbleViewAcceptButtonPressed(Browser* browser) OVERRIDE;
virtual void BubbleViewCancelButtonPressed(Browser* browser) OVERRIDE; virtual void BubbleViewCancelButtonPressed(Browser* browser) OVERRIDE;
virtual bool ShouldCloseOnDeactivate() const OVERRIDE;
private: private:
// When the user took action, the GlobalError can be dismissed. // When the user took action, the GlobalError can be dismissed.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment