Skip to content

GitLab

T
tangled
Commit 8e40418f authored by Adam Rice's avatar Adam Rice Committed by Commit Bot
Browse files
Options

Revert "[LayoutNG] Fix text-transform for 8-bit text" 

This reverts commit abcd4da5.

Reason for revert: Causing failures on Linux debug bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75629

Original change's description:
> [LayoutNG] Fix text-transform for 8-bit text
> 
> Fix a bug in CaseMappingHarfBuzzBufferFiller where 8-bit strings weren't
> up-converted to 16-bit in cases were the original and case mapped string
> differed in length which hit a CHECK in the String::Characters16 method.
> 
> Bug: 899876, 899868
> No-Try: true
> Change-Id: I5de8fbaabbc08932904846ffa4674129263f50aa
> Reviewed-on: https://chromium-review.googlesource.com/c/1330723
> Commit-Queue: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607106}

TBR=szager@chromium.org,cbiesinger@chromium.org,eae@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 899876, 899868
Change-Id: I0dbcc4d3c64cfcc9f074b6255dca09885043eed7
Reviewed-on: https://chromium-review.googlesource.com/c/1331096Reviewed-by: default avatarAdam Rice <ricea@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607156}
parent d9349484
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 16 deletions
third_party/WebKit/LayoutTests/fast/text/8-bit-text-transform-crash.html deleted 100644 → 0
View file @ d9349484
<!DOCTYPE html>
<span style="font-variant: small-caps">ß</span>
<span style="text-transform: uppercase">ß</span>
<p>
Test passes if it does not crash.
</p>
<script>
if (testRunner)
testRunner.dumpAsText();
</script>
\ No newline at end of file
third_party/blink/renderer/platform/fonts/shaping/case_mapping_harfbuzz_buffer_filler.cc
View file @ 8e40418f
...@@ -38,10 +38,8 @@ CaseMappingHarfBuzzBufferFiller::CaseMappingHarfBuzzBufferFiller( ...@@ -38,10 +38,8 @@ CaseMappingHarfBuzzBufferFiller::CaseMappingHarfBuzzBufferFiller(
case_mapped_text.Ensure16Bit(); case_mapped_text.Ensure16Bit();
if (case_mapped_text.length() != text.length()) { if (case_mapped_text.length() != text.length()) {
String original_text = text; FillSlowCase(case_map_intend, locale, text.Characters16(), text.length(),
original_text.Ensure16Bit(); start_index, num_characters);
FillSlowCase(case_map_intend, locale, original_text.Characters16(),
original_text.length(), start_index, num_characters);
return; return;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment