Commit 8e420687 authored by yawano's avatar yawano Committed by Commit bot

Revert of arc: avoid checkbox AutomationNode issue (patchset #1 id:1 of...

Revert of arc: avoid checkbox AutomationNode issue (patchset #1 id:1 of https://codereview.chromium.org/2254673003/ )

Reason for revert:
https://crbug.com/638840

Original issue's description:
> arc: avoid checkbox AutomationNode issue
>
> Avoid checkbox AutomationNode issue https://crbug.com/638498
>
> BUG=638501
> BUG=b/30906810
> TEST=tested as described in the issue
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f
> Cr-Commit-Position: refs/heads/master@{#412740}

TBR=xiyuan@chromium.org,khmel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638501

Review-Url: https://codereview.chromium.org/2257073002
Cr-Commit-Position: refs/heads/master@{#412766}
parent 1ea4168e
......@@ -196,7 +196,8 @@ var onLearnMore = function(event) {
function setMetricsMode(text, canEnable, on) {
var doc = appWindow.contentWindow.document;
var enableMetrics = doc.getElementById('enable-metrics');
enableMetrics.hidden = !canEnable;
var enableMetricsContainer = doc.getElementById('enable-metrics-container');
enableMetricsContainer.hidden = !canEnable;
enableMetrics.checked = on;
var onSettings = function(event) {
......
......@@ -48,6 +48,11 @@ webview,
width: 1px;
}
.checkbox-container {
margin: 0;
padding: 0 8px 0 0;
}
.checkbox-option {
height: 12px;
margin: 0;
......@@ -118,11 +123,6 @@ webview,
width: 640px;
}
.section-checkbox-container > input[type='checkbox'] {
flex-shrink: 0;
margin: 0 8px 0 0;
}
.section-terms {
border: 1px solid #e6e6e6;
color: rgba(0, 0, 0, 0.54);
......
......@@ -73,17 +73,23 @@
<webview id="terms-view" partition="persist:arc_support"></webview>
</div>
<label class="layout horizontal section-checkbox-container">
<input type="checkbox" class="checkbox-option" id="enable-metrics">
<div class="checkbox-container" id="enable-metrics-container" hidden>
<input type="checkbox" class="checkbox-option" id="enable-metrics">
</div>
<p class="checkbox-text" id="text-metrics"></p>
</label>
<label class="layout horizontal section-checkbox-container">
<input type="checkbox" class="checkbox-option"
id="enable-backup-restore">
<div class="checkbox-container">
<input type="checkbox" class="checkbox-option"
id="enable-backup-restore">
</div>
<p class="checkbox-text" id="text-backup-restore"></p>
</label>
<label class="layout horizontal section-checkbox-container">
<input type="checkbox" class="checkbox-option"
id="enable-location-service">
<div class="checkbox-container">
<input type="checkbox" class="checkbox-option"
id="enable-location-service">
</div>
<p class="checkbox-text" id="text-location-service"></p>
</label>
<div class="layout horizontal end-justified section-buttons">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment