Commit 8e46b420 authored by rajendrant's avatar rajendrant Committed by Chromium LUCI CQ

Revert "Fix flaky test"

This reverts commit c08b4303.

Reason for revert: Revert due to test failures

Original change's description:
> Fix flaky test
>
> Fix the path used in test server.
>
> Bug: 1166280
> Change-Id: I34fc06dc911c69d00f8dc4d193052d088f99816a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626022
> Reviewed-by: Michael Crouse <mcrouse@chromium.org>
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#843864}

TBR=rajendrant@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Ibfee8d1710479ea363bf41ea4cf02e8df400d964
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1166280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631913Reviewed-by: default avatarrajendrant <rajendrant@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843971}
parent e028f090
...@@ -105,10 +105,11 @@ class SubresourceRedirectLoggedInSitesBrowserTest ...@@ -105,10 +105,11 @@ class SubresourceRedirectLoggedInSitesBrowserTest
#define DISABLE_ON_WIN_MAC_CHROMEOS(x) x #define DISABLE_ON_WIN_MAC_CHROMEOS(x) x
#endif #endif
// TODO(crbug.com/1166280): Enable the test after fixing the flake.
// Verify that when image load gets canceled due to subsequent page load, the // Verify that when image load gets canceled due to subsequent page load, the
// subresource redirect for the image is canceled as well. // subresource redirect for the image is canceled as well.
IN_PROC_BROWSER_TEST_F(SubresourceRedirectLoggedInSitesBrowserTest, IN_PROC_BROWSER_TEST_F(SubresourceRedirectLoggedInSitesBrowserTest,
DISABLE_ON_WIN_MAC_CHROMEOS(TestCancelBeforeImageLoad)) { DISABLED_TestCancelBeforeImageLoad) {
robots_rules_server_.set_failure_mode( robots_rules_server_.set_failure_mode(
RobotsRulesTestServer::FailureMode::kTimeout); RobotsRulesTestServer::FailureMode::kTimeout);
robots_rules_server_.AddRobotsRules(GetHttpsTestURL("/"), robots_rules_server_.AddRobotsRules(GetHttpsTestURL("/"),
...@@ -122,7 +123,8 @@ IN_PROC_BROWSER_TEST_F(SubresourceRedirectLoggedInSitesBrowserTest, ...@@ -122,7 +123,8 @@ IN_PROC_BROWSER_TEST_F(SubresourceRedirectLoggedInSitesBrowserTest,
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
} }
ui_test_utils::NavigateToURL(browser(), GetHttpsTestURL("/simple.html")); ui_test_utils::NavigateToURL(browser(),
GetHttpsTestURL("/load_image/simple.html"));
FetchHistogramsFromChildProcesses(); FetchHistogramsFromChildProcesses();
RetryForHistogramUntilCountReached( RetryForHistogramUntilCountReached(
...@@ -141,11 +143,11 @@ IN_PROC_BROWSER_TEST_F(SubresourceRedirectLoggedInSitesBrowserTest, ...@@ -141,11 +143,11 @@ IN_PROC_BROWSER_TEST_F(SubresourceRedirectLoggedInSitesBrowserTest,
image_compression_server_.VerifyRequestedImagePaths({}); image_compression_server_.VerifyRequestedImagePaths({});
} }
// TODO(crbug.com/1166280): Enable the test after fixing the flake.
// Verify that when image load gets canceled due to subsequent navigation to a // Verify that when image load gets canceled due to subsequent navigation to a
// logged-in page, the subresource redirect for the image is disabled as well. // logged-in page, the subresource redirect for the image is disabled as well.
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(SubresourceRedirectLoggedInSitesBrowserTest,
SubresourceRedirectLoggedInSitesBrowserTest, DISABLED_TestCancelBeforeImageLoadForLoggedInSite) {
DISABLE_ON_WIN_MAC_CHROMEOS(TestCancelBeforeImageLoadForLoggedInSite)) {
robots_rules_server_.set_failure_mode( robots_rules_server_.set_failure_mode(
RobotsRulesTestServer::FailureMode::kTimeout); RobotsRulesTestServer::FailureMode::kTimeout);
robots_rules_server_.AddRobotsRules(GetHttpsTestURL("/"), robots_rules_server_.AddRobotsRules(GetHttpsTestURL("/"),
...@@ -160,7 +162,8 @@ IN_PROC_BROWSER_TEST_F( ...@@ -160,7 +162,8 @@ IN_PROC_BROWSER_TEST_F(
} }
ui_test_utils::NavigateToURL( ui_test_utils::NavigateToURL(
browser(), https_test_server_.GetURL("loggedin.com", "/simple.html")); browser(),
https_test_server_.GetURL("loggedin.com", "/load_image/simple.html"));
FetchHistogramsFromChildProcesses(); FetchHistogramsFromChildProcesses();
histogram_tester_.ExpectBucketCount( histogram_tester_.ExpectBucketCount(
"Login.PageLoad.DetectionType", "Login.PageLoad.DetectionType",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment