Commit 8e64dad7 authored by chinsenj's avatar chinsenj Committed by Commit Bot

cros: Refactor ash histograms to use variants for TabletOrClamshell.

The {TabletOrClamshell} token is used in various different ash
histograms but they all use the same variants. This CL extracts the
variants into a common variants tag.

Bug: 1140182
Change-Id: Ifd9b5233405b65308c09b24e0e6d7700eef2db3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533362Reviewed-by: default avatarWeilun Shi <sweilun@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826874}
parent 86320b01
...@@ -21,6 +21,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -21,6 +21,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histograms> <histograms>
<variants name="DisplayModes">
<variant name="ClamshellMode" summary="Clamshell mode"/>
<variant name="TabletMode" summary="Tablet mode"/>
</variants>
<histogram name="Ash.Accelerators.Deprecated.ShowImeMenuBubble" <histogram name="Ash.Accelerators.Deprecated.ShowImeMenuBubble"
enum="DeprecatedAcceleratorUsage" expires_after="M77"> enum="DeprecatedAcceleratorUsage" expires_after="M77">
<owner>afakhry@chromium.org</owner> <owner>afakhry@chromium.org</owner>
...@@ -88,10 +93,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -88,10 +93,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
AmbientUiMode indicates whether the user entered Ambient mode from the lock AmbientUiMode indicates whether the user entered Ambient mode from the lock
screen or from screen idle. screen or from screen idle.
</summary> </summary>
<token key="TabletOrClamshell"> <token key="TabletOrClamshell" variants="DisplayModes"/>
<variant name="ClamshellMode" summary="Clamshell mode"/>
<variant name="TabletMode" summary="Tablet mode"/>
</token>
</histogram> </histogram>
<histogram name="Ash.AmbientMode.AnimationSmoothness.PhotoTransition" units="%" <histogram name="Ash.AmbientMode.AnimationSmoothness.PhotoTransition" units="%"
...@@ -126,10 +128,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -126,10 +128,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
Among eligible users with ambient mode enabled, records the length of each Among eligible users with ambient mode enabled, records the length of each
session. The metric is uploaded when ambient mode is ended. session. The metric is uploaded when ambient mode is ended.
</summary> </summary>
<token key="TabletOrClamshell"> <token key="TabletOrClamshell" variants="DisplayModes"/>
<variant name="ClamshellMode" summary="Clamshell mode"/>
<variant name="TabletMode" summary="Tablet mode"/>
</token>
</histogram> </histogram>
<histogram name="Ash.AmbientMode.PhotoSource" enum="AmbientModePhotoSource" <histogram name="Ash.AmbientMode.PhotoSource" enum="AmbientModePhotoSource"
...@@ -193,10 +192,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -193,10 +192,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
pressed in {TabletOrClamshell}. The recorded enum value indicates the type pressed in {TabletOrClamshell}. The recorded enum value indicates the type
of the button pressed. of the button pressed.
</summary> </summary>
<token key="TabletOrClamshell"> <token key="TabletOrClamshell" variants="DisplayModes"/>
<variant name="ClamshellMode" summary="Clamshell mode"/>
<variant name="TabletMode" summary="Tablet mode"/>
</token>
</histogram> </histogram>
<histogram <histogram
...@@ -211,10 +207,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -211,10 +207,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
the region. This counts each time they move the region or resize it. It is the region. This counts each time they move the region or resize it. It is
reset whenever a user creates a new region or the count is recorded. reset whenever a user creates a new region or the count is recorded.
</summary> </summary>
<token key="TabletOrClamshell"> <token key="TabletOrClamshell" variants="DisplayModes"/>
<variant name="ClamshellMode" summary="Clamshell mode"/>
<variant name="TabletMode" summary="Tablet mode"/>
</token>
</histogram> </histogram>
<histogram name="Ash.CaptureModeController.EntryPoint.{TabletOrClamshell}" <histogram name="Ash.CaptureModeController.EntryPoint.{TabletOrClamshell}"
...@@ -225,10 +218,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -225,10 +218,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
Recorded whenever Capture mode is entered from {TabletOrClamshell}. The Recorded whenever Capture mode is entered from {TabletOrClamshell}. The
recorded enum value indicates the method used to enter Capture mode. recorded enum value indicates the method used to enter Capture mode.
</summary> </summary>
<token key="TabletOrClamshell"> <token key="TabletOrClamshell" variants="DisplayModes"/>
<variant name="ClamshellMode" summary="Clamshell mode"/>
<variant name="TabletMode" summary="Tablet mode"/>
</token>
</histogram> </histogram>
<histogram name="Ash.CaptureModeController.ScreenRecordingLength" <histogram name="Ash.CaptureModeController.ScreenRecordingLength"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment