Reland "Add installability test for when start_url has no offline response"

This is a reland of 475e9c81

The original change is reverted due to the difference between the
default value of the CheckOfflineCapability feature.
In fieldtrial_testing_config.json, the CheckOfflineCapability feature
is set to be enabled and its check_mode is "enforce". However, some
environment seems to use "warn_only" check_mode.

So use parameterized tests for the CheckNotOfflineCapableStartUrl test.

Original change's description:
> Add installability test for when start_url has no offline response
>
> The following case should not pass the offline capability check:
> - manifest's scope: /banners/
> - manifest's start_url: /banners/manifest_test_page.html?ignore
> - service worker's scope: /banners/
>
> Bug: 1157242, 965802
> Change-Id: I2832fbc102fd931aecc9d42394f5429e4c66e6aa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596902
> Commit-Queue: Asami Doi <asamidoi@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#840905}

Bug: 1163791, 965802
Change-Id: I5b7fc2697708027db5543f47800dd69fdfa005d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616645
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842421}

chrome/browser/installable/installable_manager_browsertest.cc

@@ -1425,7 +1425,6 @@ IN_PROC_BROWSER_TEST_F(InstallableManagerBrowserTest, CheckDataUrlIcon) {
                                        "/banners/manifest_data_url_icon.json"));
   run_loop.Run();
 
-
   EXPECT_FALSE(tester->manifest().IsEmpty());
   EXPECT_FALSE(tester->manifest_url().is_empty());
 
@@ -1508,6 +1507,56 @@ IN_PROC_BROWSER_TEST_P(InstallableManagerOfflineCapabilityBrowserTest,
   }
 }
 
+// The case that a service worker doesn't return an offline response for the
+// start_url, but does for the manifest scope.
+// - manifest's scope: /banners/
+// - manifest's start_url: /banners/manifest_test_page.html?ignore
+// - service worker's scope: /banners/
+IN_PROC_BROWSER_TEST_P(InstallableManagerOfflineCapabilityBrowserTest,
+                       CheckNotOfflineCapableStartUrl) {
+  // This test wants to check the service worker that doesn't support offline
+  // pages, so ignore the cases when `is_service_worker_offline_supported_` is
+  // true.
+  if (IsServiceWorkerOfflineSupported())
+    return;
+
+  base::RunLoop run_loop;
+  std::unique_ptr<CallbackTester> tester(
+      new CallbackTester(run_loop.QuitClosure()));
+
+  NavigateAndRunInstallableManager(
+      browser(), tester.get(), GetWebAppParams(),
+      GetURLOfPageWithServiceWorkerAndManifest(
+          "/banners/manifest_not_offline_capable_url.json"));
+
+  run_loop.Run();
+
+  EXPECT_FALSE(tester->manifest().IsEmpty());
+  EXPECT_FALSE(tester->manifest_url().is_empty());
+  EXPECT_FALSE(tester->primary_icon_url().is_empty());
+  EXPECT_NE(nullptr, tester->primary_icon());
+  EXPECT_TRUE(tester->valid_manifest());
+  EXPECT_TRUE(tester->splash_icon_url().is_empty());
+  EXPECT_EQ(nullptr, tester->splash_icon());
+  CheckServiceWorkerForTester(tester.get());
+
+  InstallableManager* manager = GetManager(browser());
+
+  EXPECT_FALSE(manager->manifest().IsEmpty());
+  EXPECT_FALSE(manager->manifest_url().is_empty());
+  EXPECT_TRUE(manager->valid_manifest());
+  EXPECT_EQ(1u, manager->icons_.size());
+  EXPECT_FALSE(
+      (manager->icon_url(InstallableManager::IconUsage::kPrimary).is_empty()));
+  EXPECT_NE(nullptr, (manager->icon(InstallableManager::IconUsage::kPrimary)));
+  EXPECT_EQ(NO_ERROR_DETECTED, manager->manifest_error());
+  EXPECT_EQ(NO_ERROR_DETECTED, manager->valid_manifest_error());
+  EXPECT_EQ(NO_ERROR_DETECTED,
+            (manager->icon_error(InstallableManager::IconUsage::kPrimary)));
+  EXPECT_TRUE(!manager->task_queue_.HasCurrent());
+  CheckServiceWorkerForInstallableManager(manager);
+}
+
 IN_PROC_BROWSER_TEST_F(InstallableManagerBrowserTest,
                        CheckNestedCallsToGetData) {
   // Verify that we can call GetData while in a callback from GetData.

chrome/test/data/banners/manifest_not_offline_capable_url.json

+{
+  "name": "Manifest test app with not offline capable start_url",
+  "icons": [
+    {
+      "src": "launcher-icon-1x.png",
+      "sizes": "48x48",
+      "type": "image/png"
+    },
+    {
+      "src": "launcher-icon-1-5x.png",
+      "sizes": "72x72",
+      "type": "image/png"
+    },
+    {
+      "src": "launcher-icon-2x.png",
+      "sizes": "96x96",
+      "type": "image/png",
+      "purpose": "any monochrome"
+    },
+    {
+      "src": "launcher-icon-3x.png",
+      "sizes": "144x144",
+      "type": "image/png"
+    },
+    {
+      "src": "launcher-icon-4x.png",
+      "sizes": "192x192",
+      "type": "image/png"
+    },
+    {
+      "src": "image-512px.png",
+      "sizes": "512x512",
+      "type": "image/png"
+    }
+  ],
+  "start_url": "manifest_test_page.html?ignore",
+  "display": "standalone",
+  "orientation": "landscape"
+}

components/webapps/installable/installable_manager.h

@@ -90,9 +90,6 @@ class InstallableManager
   FRIEND_TEST_ALL_PREFIXES(InstallableManagerBrowserTest,
                            ManagerBeginsInEmptyState);
   FRIEND_TEST_ALL_PREFIXES(InstallableManagerBrowserTest, ManagerInIncognito);
-  FRIEND_TEST_ALL_PREFIXES(InstallableManagerBrowserTest, CheckWebapp);
-  FRIEND_TEST_ALL_PREFIXES(InstallableManagerBrowserTest,
-                           CheckLazyServiceWorkerPassesWhenWaiting);
   FRIEND_TEST_ALL_PREFIXES(InstallableManagerBrowserTest,
                            CheckLazyServiceWorkerNoFetchHandlerFails);
   FRIEND_TEST_ALL_PREFIXES(InstallableManagerBrowserTest,
@@ -101,6 +98,8 @@ class InstallableManager
                            CheckLazyServiceWorkerPassesWhenWaiting);
   FRIEND_TEST_ALL_PREFIXES(InstallableManagerOfflineCapabilityBrowserTest,
                            CheckWebapp);
+  FRIEND_TEST_ALL_PREFIXES(InstallableManagerOfflineCapabilityBrowserTest,
+                           CheckNotOfflineCapableStartUrl);
 
   using IconPurpose = blink::mojom::ManifestImageResource_Purpose;