Skip to content

GitLab

T
tangled
Commit 8e8c88b3 authored by Darren Shen's avatar Darren Shen Committed by Commit Bot
Browse files
Options

[css-typed-om] Clean up CSSUnitValue tests. 

This patch:
- Adds mutation tests for CSSUnitValue.value.
- Clean up code style.

Bug: 774887
Change-Id: I5a6398c4a4a2ad86f60165780ee8d48bb3d8b0a1
Reviewed-on: https://chromium-review.googlesource.com/954642
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: default avatarnainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543959}
parent 29b26a4b
Hide whitespace changes
Inline Side-by-side
Showing with 53 additions and 2 deletions
third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue.tentative-expected.txt → third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue-expected.txt
View file @ 8e8c88b3
This is a testharness.js-based test.
PASS Constructing CSSUnitValue with an empty string as the unit throws a TypeError
PASS Constructing CSSUnitValue with an invalid unit as the unit throws a TypeError
PASS Constructing CSSUnitValue with an unknown unit throws a TypeError
PASS Constructing CSSUnitValue with a empty string unit throws a TypeError
PASS CSSUnitValue can be constructed with number
PASS CSSUnitValue can be constructed with percent
PASS CSSUnitValue can be constructed with em
......
third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue-value.html 0 → 100644
View file @ 8e8c88b3
<!doctype html>
<meta charset="utf-8">
<title>CSSUnitValue.value</title>
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#cssunitvalue">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<body>
<div id="log"></div>
<script>
'use strict';
test(() => {
const result = new CSSUnitValue(-3.14, 'px');
result.value = 3.14;
assert_equals(result.value, 3.14, 'value reflects new value');
assert_equals(result.unit, 'px', 'unit does not change');
}, 'CSSUnitValue.value can be updated to a different value');
</script>
third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue.tentative.html → third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue.html
View file @ 8e8c88b3
<!doctype html>
<meta charset="utf-8">
<title>CSSUnitValue tests</title>
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#simple-numeric">
<title>CSSUnitValue Constructor</title>
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-cssunitvalue-cssunitvalue">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../../resources/testhelper.js"></script>
<body>
<div id="log"></div>
<script>
'use strict';
const gInvalidTestUnits = [
{ unit: '', desc: 'an empty string' },
{ unit: 'lemon', desc: 'an invalid unit' },
];
test(() => {
assert_throws(new TypeError(), () => new CSSUnitValue(0, 'lemon'));
}, 'Constructing CSSUnitValue with an unknown unit throws a TypeError');
for (const {unit, desc} of gInvalidTestUnits) {
test(() => {
assert_throws(new TypeError(), () => new CSSUnitValue(0, unit));
}, 'Constructing CSSUnitValue with ' + desc + ' as the unit throws a TypeError');
}
test(() => {
assert_throws(new TypeError(), () => new CSSUnitValue(0, ''));
}, 'Constructing CSSUnitValue with a empty string unit throws a TypeError');
for (const unit of gValidUnits) {
test(() => {
const result = new CSSUnitValue(-3.14, unit);
assert_equals(result.value, -3.14);
assert_equals(result.unit, unit.toLowerCase());
assert_not_equals(result, null, 'a CSSUnitValue is created');
assert_equals(result.value, -3.14,
'value is same as given by constructor');
assert_equals(result.unit, unit.toLowerCase(),
'unit is same as given by constructor');
}, 'CSSUnitValue can be constructed with ' + unit);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment