Commit 8eadbd2d authored by Alice Wang's avatar Alice Wang Committed by Commit Bot

[Android][WebSignin] Adjust methods scope of WebSigninBridge

This CL adjusts the scope of the methods called only in native in
WebSigninBridge.

Bug: 1124737
Change-Id: I353dea64e7382da0dac4569cd4a4b418d7c869c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421112Reviewed-by: default avatarTanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808929}
parent 81b06232
...@@ -26,7 +26,7 @@ public class WebSigninBridge { ...@@ -26,7 +26,7 @@ public class WebSigninBridge {
/** /**
* Sign-in completed successfully and the primary account is available in the cookie jar. * Sign-in completed successfully and the primary account is available in the cookie jar.
*/ */
void onSigninSucceded(); void onSigninSucceeded();
/** /**
* Sign-in process failed. * Sign-in process failed.
...@@ -75,12 +75,12 @@ public class WebSigninBridge { ...@@ -75,12 +75,12 @@ public class WebSigninBridge {
} }
@CalledByNative @CalledByNative
static void onSigninSucceded(Listener listener) { private static void onSigninSucceded(Listener listener) {
listener.onSigninSucceded(); listener.onSigninSucceeded();
} }
@CalledByNative @CalledByNative
static void onSigninFailed(Listener listener, GoogleServiceAuthError error) { private static void onSigninFailed(Listener listener, GoogleServiceAuthError error) {
listener.onSigninFailed(error); listener.onSigninFailed(error);
} }
......
...@@ -137,7 +137,7 @@ public class AccountPickerDelegate implements WebSigninBridge.Listener { ...@@ -137,7 +137,7 @@ public class AccountPickerDelegate implements WebSigninBridge.Listener {
*/ */
@MainThread @MainThread
@Override @Override
public void onSigninSucceded() { public void onSigninSucceeded() {
ThreadUtils.assertOnUiThread(); ThreadUtils.assertOnUiThread();
mCurrentTab.loadUrl(new LoadUrlParams(mContinueUrl)); mCurrentTab.loadUrl(new LoadUrlParams(mContinueUrl));
} }
......
...@@ -123,7 +123,7 @@ public class AccountPickerDelegateTest { ...@@ -123,7 +123,7 @@ public class AccountPickerDelegateTest {
calledInOrder.verify(mWebSigninBridgeFactoryMock) calledInOrder.verify(mWebSigninBridgeFactoryMock)
.create(mProfileMock, coreAccountInfo, mDelegate); .create(mProfileMock, coreAccountInfo, mDelegate);
calledInOrder.verify(mSigninManagerMock).signin(eq(coreAccountInfo), any()); calledInOrder.verify(mSigninManagerMock).signin(eq(coreAccountInfo), any());
mDelegate.onSigninSucceded(); mDelegate.onSigninSucceeded();
verify(mTabMock).loadUrl(mLoadUrlParamsCaptor.capture()); verify(mTabMock).loadUrl(mLoadUrlParamsCaptor.capture());
LoadUrlParams loadUrlParams = mLoadUrlParamsCaptor.getValue(); LoadUrlParams loadUrlParams = mLoadUrlParamsCaptor.getValue();
Assert.assertEquals("Continue url does not match!", CONTINUE_URL, loadUrlParams.getUrl()); Assert.assertEquals("Continue url does not match!", CONTINUE_URL, loadUrlParams.getUrl());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment