Commit 8eb278f5 authored by Jaeyong Bae's avatar Jaeyong Bae Committed by Commit Bot

Replace selectable_list_row_padding more generic

This patch means replace selectable_list_layout_row_padding with
default_list_row_padding. It is used for more generic value.
This has been discussed in other patches[1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2049424

Bug: none
Change-Id: I4705c0e1208d094b4ce8704ed81dcffb6f32b7e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074998Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#745978}
parent 2f36710a
...@@ -43,8 +43,8 @@ ...@@ -43,8 +43,8 @@
android:id="@+id/more" android:id="@+id/more"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="match_parent" android:layout_height="match_parent"
android:paddingStart="@dimen/selectable_list_layout_row_padding" android:paddingStart="@dimen/default_list_row_padding"
android:paddingEnd="@dimen/selectable_list_layout_row_padding" android:paddingEnd="@dimen/default_list_row_padding"
android:background="@null" android:background="@null"
android:src="@drawable/ic_more_vert_24dp" android:src="@drawable/ic_more_vert_24dp"
app:menuMaxWidth="@dimen/pref_languages_item_popup_width" app:menuMaxWidth="@dimen/pref_languages_item_popup_width"
......
...@@ -12,8 +12,8 @@ ...@@ -12,8 +12,8 @@
android:id="@+id/more" android:id="@+id/more"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="match_parent" android:layout_height="match_parent"
android:paddingStart="@dimen/selectable_list_layout_row_padding" android:paddingStart="@dimen/default_list_row_padding"
android:paddingEnd="@dimen/selectable_list_layout_row_padding" android:paddingEnd="@dimen/default_list_row_padding"
android:background="@null" android:background="@null"
android:src="@drawable/ic_more_vert_24dp" android:src="@drawable/ic_more_vert_24dp"
app:tint="@color/default_icon_color_tint_list" app:tint="@color/default_icon_color_tint_list"
......
...@@ -52,8 +52,8 @@ public class HistoryItemView extends SelectableItemView<HistoryItem> implements ...@@ -52,8 +52,8 @@ public class HistoryItemView extends SelectableItemView<HistoryItem> implements
mMinIconSize = getResources().getDimensionPixelSize(R.dimen.default_favicon_min_size); mMinIconSize = getResources().getDimensionPixelSize(R.dimen.default_favicon_min_size);
mDisplayedIconSize = getResources().getDimensionPixelSize(R.dimen.default_favicon_size); mDisplayedIconSize = getResources().getDimensionPixelSize(R.dimen.default_favicon_size);
mIconGenerator = FaviconUtils.createCircularIconGenerator(getResources()); mIconGenerator = FaviconUtils.createCircularIconGenerator(getResources());
mEndPadding = context.getResources().getDimensionPixelSize( mEndPadding =
R.dimen.selectable_list_layout_row_padding); context.getResources().getDimensionPixelSize(R.dimen.default_list_row_padding);
mStartIconSelectedColorList = mStartIconSelectedColorList =
AppCompatResources.getColorStateList(context, R.color.default_icon_color_inverse); AppCompatResources.getColorStateList(context, R.color.default_icon_color_inverse);
......
...@@ -13,8 +13,8 @@ ...@@ -13,8 +13,8 @@
android:id="@+id/empty_container" android:id="@+id/empty_container"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginEnd="@dimen/selectable_list_layout_row_padding" android:layout_marginEnd="@dimen/default_list_row_padding"
android:layout_marginStart="@dimen/selectable_list_layout_row_padding" android:layout_marginStart="@dimen/default_list_row_padding"
android:gravity="center" android:gravity="center"
android:padding="@dimen/card_padding" > android:padding="@dimen/card_padding" >
......
...@@ -42,8 +42,8 @@ ...@@ -42,8 +42,8 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="center" android:layout_gravity="center"
android:layout_marginStart="@dimen/selectable_list_layout_row_padding" android:layout_marginStart="@dimen/default_list_row_padding"
android:layout_marginEnd="@dimen/selectable_list_layout_row_padding" android:layout_marginEnd="@dimen/default_list_row_padding"
android:visibility="gone"> android:visibility="gone">
<org.chromium.ui.widget.TextViewWithLeading <org.chromium.ui.widget.TextViewWithLeading
......
...@@ -52,7 +52,6 @@ ...@@ -52,7 +52,6 @@
<dimen name="list_item_end_icon_width">56dp</dimen> <dimen name="list_item_end_icon_width">56dp</dimen>
<!-- SelectableListLayout dimensions --> <!-- SelectableListLayout dimensions -->
<dimen name="selectable_list_layout_row_padding">16dp</dimen>
<dimen name="selectable_list_action_bar_end_padding">6dp</dimen> <dimen name="selectable_list_action_bar_end_padding">6dp</dimen>
<dimen name="toolbar_wide_display_start_offset">13dp</dimen> <dimen name="toolbar_wide_display_start_offset">13dp</dimen>
<dimen name="search_toolbar_modern_bg_top_bottom_inset">8dp</dimen> <dimen name="search_toolbar_modern_bg_top_bottom_inset">8dp</dimen>
...@@ -73,4 +72,7 @@ ...@@ -73,4 +72,7 @@
<dimen name="text_bubble_arrow_width">20dp</dimen> <dimen name="text_bubble_arrow_width">20dp</dimen>
<dimen name="text_bubble_arrow_height">10dp</dimen> <dimen name="text_bubble_arrow_height">10dp</dimen>
<dimen name="iph_pulse_baseline_radius">16dp</dimen> <dimen name="iph_pulse_baseline_radius">16dp</dimen>
<!-- Default list dimensions -->
<dimen name="default_list_row_padding">16dp</dimen>
</resources> </resources>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment